Skip to content

feature/fish completion#2463

Open
maxandersen wants to merge 17 commits into
remkop:mainfrom
maxandersen:feature/fish-completion
Open

feature/fish completion#2463
maxandersen wants to merge 17 commits into
remkop:mainfrom
maxandersen:feature/fish-completion

Conversation

@maxandersen

Copy link
Copy Markdown
Contributor

rebased #1925 as I realized fish now works with jbang scripts so I got a good reason to make this work :)

I've added basic support to the GenerateCompletion command for choosing which variant to generate bash/zsh or fish.

But I didn't grok what the meaning is for the AutoComplete which generates code does does not run without user modification so i did not add/change that.

I've tested it in jbang at jbangdev/jbang#2195 and would love to see a picocli release with this included so I can release jbang with fish completion :)

@maxandersen

Copy link
Copy Markdown
Contributor Author

screenshots on how it looks:

Screenshot 2025-08-25 at 16 32 03 Screenshot 2025-08-25 at 16 32 52

@maxandersen

Copy link
Copy Markdown
Contributor Author

im going to temporarily not fail the dejagnu tests as not able to run dejagnu on osx. (fails when running fish)

@remkop

remkop commented Sep 2, 2025

Copy link
Copy Markdown
Owner

Hi @maxandersen thank you for helping push this forward.
Fish completion, exciting!

I see this one test that now seems to be failing for some reason:

> Task :picocli-codegen-tests-java9plus:test

NativeImageConfigGeneratorProcessorTest > testGenerateReflectForNestedInnerEnumWithoutPackage FAILED
    com.google.common.truth.ComparisonFailureWithFacts at NativeImageConfigGeneratorProcessorTest.java:235

62 tests completed, 1 failed, 6 skipped

Does this need to be added to picocli-codegen-tests-java9plus/src/test/resources/expected-filelist-reflect.json?

  {
    "name" : "picocli.AutoComplete$GenerateCompletion$Shell",
    "allDeclaredConstructors" : true,
    "allPublicConstructors" : true,
    "allDeclaredMethods" : true,
    "allPublicMethods" : true
  },

@maxandersen

Copy link
Copy Markdown
Contributor Author

sounds about right. pushed.

@maxandersen

Copy link
Copy Markdown
Contributor Author

the failure on java 9 is that it does not seem available on github actions?
also for java 6 is failure - but i can't reproduce locally; can one see the test results so can see actual comparison failure?

@remkop remkop added this to the 4.8 milestone May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants