Skip to content

Align code style configuration to Visual Studio extension #76

@AidenFuller

Description

@AidenFuller

Just a question regarding whether there's appetite to change the configurations for the plugin to align more to the Visual Studio extensions.

As an example, the Visual Studio extension uses bools to specify whether or not to indent the children of a node type. e.g. "IndentFeatureChildren", "IndentScenarioChildren", etc.
https://github.com/reqnroll/Reqnroll.VisualStudio/blob/b80f37cdac6a234a42093932f63db01ac44c2591/Reqnroll.VisualStudio/Configuration/GherkinFormatConfiguration.cs
These are also able to be driven by .editorconfig fully

Whereas the Rider plugin is expecting us to specify how many indents we expect to use
https://github.com/reqnroll/Reqnroll.Rider/blob/main/src/dotnet/ReSharperPlugin.ReqnrollRiderPlugin/Formatting/GherkinFormatSettingsKey.cs
Is a multi-indent something that developers will even use?

Another issue is that the editorconfig doesn't align to the VS extension, and also appears to be not working properly at the moment anyway.

Is there appetite to make adjustments here to match parity and allow cross-compatibility with the Visual Studio extension? I'm more than happy to write these changes to the configuration myself and raise a PR, but I don't want to do it if it's going to cause friction or if there's an opposition to doing something like this

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions