Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Update maximum valid year to be hard coded as 2025 #632

Open
2 of 5 tasks
aflinchb opened this issue Jan 6, 2021 · 0 comments
Open
2 of 5 tasks

Update maximum valid year to be hard coded as 2025 #632

aflinchb opened this issue Jan 6, 2021 · 0 comments
Labels
Bug Something isn't working C# Helium Helium Issues Java Node

Comments

@aflinchb
Copy link
Contributor

aflinchb commented Jan 6, 2021 •
edited
Loading

Description

With the changes to standardize the HTTP 400 error messages across all apps, it was decided to hard code 2025 as the max valid year. While the error message reflects this, the actual validation step in the apps were not also updated to validate against a hardcoded max year.

  • Update Parameter Validation spec in helium repo
  • Update typescript app to validate on max year 2025 (hardcoded)
  • Update java app to validate on max year 2025 (hardcoded)
  • Update csharp app to validate on max year 2025 (hardcoded)
  • Update swagger and copy to all repos
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working C# Helium Helium Issues Java Node
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aflinchb