Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging with sanity-plugin-mapbox-input ? #1

Open
Grsmto opened this issue Jun 29, 2020 · 1 comment
Open

Merging with sanity-plugin-mapbox-input ? #1

Grsmto opened this issue Jun 29, 2020 · 1 comment

Comments

@Grsmto
Copy link

Grsmto commented Jun 29, 2020

Hey!
I built sanity-plugin-mapbox-input some time ago, just seeing this now.
They seem to do pretty much the same thing, however I noticed that:

  • yours seems more advanced with options and all
  • mine is using Mapbox lib and not Leaflet, so it looks better (imo) and has geocoding support (which is actually pretty useful I think).

Screenshot 2020-06-29 at 14 02 53

I think it would be wise to merge them or just redirect one to the other. Let me know what you think!

@Grsmto Grsmto changed the title Same thing as sanity-plugin-mapbox-input ? Merging with sanity-plugin-mapbox-input ? Jun 29, 2020
@rexxars
Copy link
Owner

rexxars commented Jul 1, 2020

Hi!

That looks really nice, and I really appreciate the sentiment here!

I'm planning on extending this plugin with more options and types (annotated map markers, geo polylines) and I really want to keep it as "open" as possible. Switching to mapbox might result in nicer looking maps, but it also requires you to get an API key and such...

I'll give it some thought, but I'm leaning towards keeping this using leaflet which allows for using both mapbox and openstreetmaps tiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants