Conversation
uses less memory, likely speeds up lasso as well
Collaborator
Author
|
I am not sure if this is important. But I observed that in the tests, there is one specific feature (299) that always disappears in the tests. I.e. it was selected before, but not anymore. Not sure if that reveals some unexpected behaviour, I will look into it. |
Collaborator
|
Thank you for the update! Reducing to half memory is nice.
In general, the results must be identical. Could you check the estimated parameter? |
Collaborator
Author
Collaborator
Author
|
@myamada0321 I found the bug in the re-implementation; now the original tests pass. Please have a look, and let me know if we should merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hi @myamada0321,
As we discussed, I implement in this patch a speed-up for HSIC Lasso. When we vectorized the kernel matrix, I use only the lower triangle (diagonal included). Hence, this implementation uses half the memory. LARS might be faster as well.
I had to adapt some tests as well. It seems this causes the reordering of some features, but roughly the same features are selected.
Let me know if you find any issues with this version.
Cheers,
H.