Skip to content
This repository has been archived by the owner on Oct 24, 2019. It is now read-only.

Secure update mechanism #26

Open
1 of 2 tasks
rlee287 opened this issue Nov 27, 2016 · 2 comments
Open
1 of 2 tasks

Secure update mechanism #26

rlee287 opened this issue Nov 27, 2016 · 2 comments

Comments

@rlee287
Copy link
Owner

rlee287 commented Nov 27, 2016

Feature Request

Description of feature:

  • 1. Pyautoupdate needs some mechanism for securing the downloading of files from the internet.
  • 2. Symlink and duplicate file checks are needed to detect duplicate files and handle symlinks properly.

Rationale for feature:

  1. Without any kind of securing, a MITM attack could easily inject malicious code into an update.
  2. Duplicate files may cause problems and unpredictability. Moreover, symlink attacks could potentially be used to overwrite critical system files.

Possible implementation:

  1. requests can already handle HTTPS properly. This could be mandated. In addition, protocols such as SFTP or SSH could also be used.
  2. Duplicates can be checked for and removed during replacing process (emitting warnings as well)
@rlee287
Copy link
Owner Author

rlee287 commented Jan 23, 2017

Turning into general checklist for securing the update chain.

@rlee287
Copy link
Owner Author

rlee287 commented Feb 10, 2017

For point 1:

  • Disallow HTTP, allow only HTTPS
  • Possibly allow SFTP or other secure protocls
  • Use pycrypto to support code signatures (verify identity while secure transfer can only verify integrity?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant