Devices that haven't connected since boot do not get updated despite fallback enabled and allowlist

[codeandsolder]

_do_full_sync only updates devices that have been seen before in he current session so if a device has been set as online before and disconnected before session start they will not be updated until they connect next.
For filterlist_is_denylist = false (I'm not sure when you'd realistically want "true" TBH) this could be solved by using the filter instead of _last_seen_clients as the starting point, I can prepare a pull request but wanted to ask if it's wanted and if you have any input.
I'm also not sure if tracking what interface the user is connected to is useful, adding devices on all tracked interfaces into one set would streamline things a lot.

[rmoesbergen]

Hi @codeandsolder ,
I'm not sure I understand the issue, nor what you mean by 'session'. Devices that have been seen before and are currently not online will be set to 'offline' during a full sync. Devices that are unknown (never been seen before) will not be set, but I don't see how that could be fixed, since we don't know about the device. But maybe a PR is best to explain whay you mean :)

Regarding your second remark about tracking per interface: this is required because events don't always happen in the 'right' order. E.g. when roaming to a different interface, a device may fist connect on the second interface, then disonnect on the first one. (iPhones do this). If there was only one list, the device would be set as offline, which is incorrect.

[codeandsolder]

@rmoesbergen because _last_seen_clients is not preserved between restarts if a device is connected when the script stops for any reason and disconnects before it starts it will not get updated until it connects again. I know it's an edge case but it has happened to me in deployment.
The following (at line 100) solves the issue, I can rework it to take the filter as blacklist mode into account (and also make messages only get logged on changes because as is having a fallback_sync_interval set spams the log absurdly) if you want.
self._last_seen_clients: set[tuple[str, str]] = set([(self._settings.interfaces[0], x) for x in self._settings.filter])