Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Monaco Editor #17

Open
A1Liu opened this issue Feb 21, 2023 · 2 comments
Open

Cache Monaco Editor #17

A1Liu opened this issue Feb 21, 2023 · 2 comments

Comments

@A1Liu
Copy link
Collaborator

A1Liu commented Feb 21, 2023 •
edited
Loading

It's very difficult to use Robin when offline, since Monaco is served via CDN.

Some info at:
Issue 25 in https://github.com/suren-atoyan/monaco-loader
@A1Liu
Copy link
Collaborator Author

A1Liu commented Feb 22, 2023

OK it turns out packaging the monaco editor is a giant pain in the ass. It might be better to include the transpiled monaco assets in the public folder of frontend and have @monaco-editor/loader read from the local assets instead of the CDN.

@karimsa karimsa changed the title Package Monaco Editor Cache Monaco Editor Feb 28, 2023
@karimsa
Copy link
Member

karimsa commented Feb 28, 2023

Discussed offline: we can look into proxying the request to the CDN, and caching onto disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karimsa @A1Liu