Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing chapter mark images produces ID3 issues #121

Open
spiderpug opened this issue Jul 21, 2022 · 1 comment
Open

Writing chapter mark images produces ID3 issues #121

spiderpug opened this issue Jul 21, 2022 · 1 comment

Comments

@spiderpug
Copy link

I'm trying to use the Gem to write chapter marks to MP3. These chapter marks may also contain images.

I created a simple repository to demonstrate what I'm doing:

https://github.com/spiderpug/taglib-chapter-mark-images-minimal

Expectation

ffprobe output.mp3 should show the chapter marks.

Actual

ffprobe does not detect any chapter marks.

I was able to nail it down to the usage of chapter_frame.add_embedded_frame. If any of those frames (TIT2, APIC) contains more than ~120 bytes of data, the written tag size is incorrect.

To reproduce how it should look like in ffprobe, replace data['image_data'] = File.read('chap.jpg')
with data['image_data'] = 'abcd'. Then the chapter marks can be read correctly.

Do I have the wrong logic to begin with?

@jacobvosmaer
Copy link
Collaborator

jacobvosmaer commented Jul 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants