fix memory leak, add tag to malformed node

Author: lukewilliamboswell

src/check/parse/IR.zig

@@ -23,6 +23,7 @@ errors: []const Diagnostic,
 pub fn deinit(self: *IR) void {
     defer self.tokens.deinit();
     defer self.store.deinit();
+    self.store.gpa.free(self.errors);
 }
 
 /// Diagnostics related to parsing
@@ -1065,7 +1066,18 @@ pub const NodeStore = struct {
                 } };
             },
             .malformed => {
-                return .malformed;
+                // TODO -- what should we do here?
+                const reason: Diagnostic.Tag = @enumFromInt(node.data.lhs);
+                // switch (reason) {
+                //     .missing_header => {
+                //         // std.debug.print("MISSING HEADER: {}\n", .{reason});
+                //         return .malformed;
+                //     },
+                //     else => {
+                //         @panic("ASDFASDF");
+                //     },
+                // }
+                return .{ .malformed = .{ .reason = reason } };
             },
             else => {
                 std.debug.panic("Expected a valid header tag, got {s}", .{@tagName(node.tag)});
@@ -1602,7 +1614,9 @@ pub const NodeStore = struct {
             // TODO: complete this
             region: Region,
         },
-        malformed,
+        malformed: struct {
+            reason: Diagnostic.Tag,
+        },
 
         const AppHeaderRhs = packed struct { num_packages: u10, num_provides: u22 };
 
@@ -1617,8 +1631,10 @@ pub const NodeStore = struct {
 
                     return header_node;
                 },
-                .malformed => {
-                    return sexpr.Expr.init(env.gpa, "malformed");
+                .malformed => |a| {
+                    var node = sexpr.Expr.init(env.gpa, "malformed");
+                    node.appendStringChild(env.gpa, @tagName(a.reason));
+                    return node;
                 },
                 else => @panic("not implemented"),
             }

src/coordinate.zig

@@ -462,6 +462,7 @@ fn findRootOfPackage(
 const ParsePackageDepsErr = union(enum) {
     failed_to_canonicalize_root_file: Filesystem.CanonicalizeError,
     failed_to_read_root_file: Filesystem.ReadError,
+    malformed_header,
 };
 
 fn parseDependenciesFromPackageRoot(
@@ -507,7 +508,8 @@ fn parseDependenciesFromPackageRoot(
             .len = 0,
         } },
         .malformed => {
-            @panic("TODO -- what should we do for a malformed node here?? raise a compiler problem I assume");
+            // @Sam -- does this look right?
+            return ParsePackageDepsErr.malformed_header;
         },
     };
 

src/fmt.zig

@@ -436,8 +436,11 @@ fn formatHeader(fmt: *Formatter, hi: HeaderIdx) void {
             fmt.newline();
         },
         .malformed => {
-            fmt.pushAll("<malformed_header>");
-            fmt.newline();
+            // TODO what should we do here?
+            // const node = fmt.ast.store.nodes.get(@enumFromInt(hi.id));
+            // const source = fmt.ast.resolve(node.main_token);
+            // std.debug.print("MALFORMED SOURCE {s}\n", .{source});
+            // fmt.pushAll(source);
         },
         else => {
             std.debug.panic("TODO: Handle formatting {s}", .{@tagName(header)});

src/snapshot.zig

@@ -305,7 +305,7 @@ fn processSnapshotFile(gpa: Allocator, snapshot_path: []const u8, maybe_fuzz_cor
     defer parse_ast.deinit();
 
     if (parse_ast.errors.len > 0) {
-        warn("file {s}: contained {d} errors, skipping", .{ snapshot_path, parse_ast.errors.len });
+        warn("skipping file {s} as it contains {d} errors", .{ snapshot_path, parse_ast.errors.len });
         return false;
     }
 

src/snapshots/003.txt

@@ -1,7 +1,6 @@
 ~~~META
 description=Import statement
 ~~~SOURCE
-<malformed_header>
 
 modAle
 
@@ -12,7 +11,7 @@ import json.Json
 decoder = Utf8.decode
 ~~~PARSE
 (file
-    (malformed)
+    (malformed 'missing_header')
     (ident '' 'modAle')
     (list
         (ident '' 'decoder'))