Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm repl: panics/crashing still displays "normal" output #6066

Open
JRMurr opened this issue Nov 22, 2023 · 1 comment
Open

wasm repl: panics/crashing still displays "normal" output #6066

JRMurr opened this issue Nov 22, 2023 · 1 comment
Labels
bug Something isn't working repl Relates to `roc repl`

Comments

@JRMurr
Copy link
Contributor

JRMurr commented Nov 22, 2023

Found during #6062

If you run code that causes a panic (like div by 0) you see the panic output but a nonsense answer below

image

Similar behavior happens for a function that calls crash

image

I can see the argument that showing the type sig would be nice so might be worth to keep that still

@folkertdev
Copy link
Contributor

it also isn't great with the native repl

» 1 / 0
This Roc code crashed with: "Decimal division by 0!"

<function> : Frac *

much of the code is shared between them so I guess that makes sense. Needs improvement!

@skyqrose skyqrose added bug Something isn't working error-messages Related to the quality of error messages repl Relates to `roc repl` and removed error-messages Related to the quality of error messages labels Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repl Relates to `roc repl`
Projects
None yet
Development

No branches or pull requests

3 participants