Skip to content

Commit d457d1c

Browse files
Fix recompose (google-map-react#547)
* Create our own createHelper, its not in recompose anymore * Use our withStateSelector * Proper apiKey usage * Replace apiKey with bootstrapUrlKeys * No need of true value in html * Use lodash.omit instead in dev * Remove unused file * Remove unnecessary extra folder utils * Upgrade recompose again * Oops! Move lodash.omit to devDependencies * Fix webpack files styles * Make examples bigger in width
1 parent 486bccf commit d457d1c

19 files changed

+94
-79
lines changed

develop/GMap.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,18 @@ export const gMap = (
3333
}
3434
) => (
3535
<GoogleMapReact
36-
draggable={draggable}
36+
bootstrapURLKeys={{
37+
key: 'AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps',
38+
}}
3739
style={style}
3840
options={options}
41+
draggable={draggable}
3942
hoverDistance={hoverDistance}
40-
center={center}
4143
zoom={zoom}
44+
center={center}
4245
onChange={onChange}
4346
onChildMouseEnter={onChildMouseEnter}
4447
onChildMouseLeave={onChildMouseLeave}
45-
heatmapLibrary
4648
>
4749
{markers}
4850
</GoogleMapReact>

develop/GMapHeatmap.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,20 @@ export const gMapHeatmap = (
3333
}
3434
) => (
3535
<GoogleMapReact
36-
draggable={draggable}
36+
bootstrapURLKeys={{
37+
key: 'AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps',
38+
}}
3739
style={style}
3840
options={options}
41+
draggable={draggable}
3942
hoverDistance={hoverDistance}
40-
center={center}
4143
zoom={zoom}
44+
center={center}
4245
onChange={onChange}
4346
onChildMouseEnter={onChildMouseEnter}
4447
onChildMouseLeave={onChildMouseLeave}
45-
heatmapLibrary
4648
heatmap={heatmapData}
49+
heatmapLibrary
4750
>
4851
{markers}
4952
</GoogleMapReact>

develop/GMapLayers.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,23 @@ export const gMap = (
3333
}
3434
) => (
3535
<GoogleMapReact
36-
draggable={draggable}
36+
bootstrapURLKeys={{
37+
key: 'AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps',
38+
}}
3739
style={style}
3840
options={options}
41+
draggable={draggable}
3942
hoverDistance={hoverDistance}
40-
center={center}
4143
zoom={zoom}
44+
center={center}
45+
onChange={onChange}
46+
onChildMouseEnter={onChildMouseEnter}
47+
onChildMouseLeave={onChildMouseLeave}
4248
layerTypes={
4349
zoom > 12
4450
? []
4551
: zoom > 10 ? ['TrafficLayer'] : ['TrafficLayer', 'TransitLayer']
4652
}
47-
onChange={onChange}
48-
onChildMouseEnter={onChildMouseEnter}
49-
onChildMouseLeave={onChildMouseLeave}
50-
heatmapLibrary
5153
>
5254
{markers}
5355
</GoogleMapReact>

develop/GMapOptim.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,19 @@ export const gMap = (
3939
}
4040
) => (
4141
<GoogleMapReact
42+
bootstrapURLKeys={{
43+
key: 'AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps',
44+
}}
4245
style={style}
4346
options={options}
47+
draggable={draggable}
4448
hoverDistance={hoverDistance}
45-
center={center}
4649
zoom={zoom}
50+
center={center}
4751
onChange={onChange}
4852
onChildMouseEnter={onChildMouseEnter}
4953
onChildMouseLeave={onChildMouseLeave}
50-
draggable={draggable}
5154
experimental
52-
heatmapLibrary
5355
>
5456
{markers}
5557
</GoogleMapReact>

develop/GMapResizable.js

+7-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import GoogleMapReact from '../src';
1818
import SimpleMarker from './markers/SimpleMarker';
1919

2020
import ptInBounds from './utils/ptInBounds';
21+
import withStateSelector from './utils/withStateSelector';
2122

2223
export const gMapResizable = (
2324
{
@@ -33,18 +34,19 @@ export const gMapResizable = (
3334
}
3435
) => (
3536
<GoogleMapReact
36-
draggable={draggable}
37+
bootstrapURLKeys={{
38+
key: 'AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps',
39+
}}
3740
style={style}
3841
options={options}
42+
draggable={draggable}
3943
hoverDistance={hoverDistance}
40-
center={center}
4144
zoom={zoom}
45+
center={center}
4246
onChange={onChange}
4347
onChildMouseEnter={onChildMouseEnter}
4448
onChildMouseLeave={onChildMouseLeave}
45-
resetBoundsOnResize={true}
46-
apiKey={'AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps'}
47-
heatmapLibrary={true}
49+
resetBoundsOnResize
4850
>
4951
{markers}
5052
</GoogleMapReact>

develop/Layout.sass

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
min-height: 90vh
44
flex-direction: column
55
margin: 0 1px 0 1px
6-
width: 100vh
6+
width: 100vw
77
.header
88
height: 2em
99
background-color: #004336

develop/utils/createEagerFactory.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import createEagerElementUtil from './utils/createEagerElementUtil';
1+
import createEagerElementUtil from './createEagerElementUtil';
22
import isReferentiallyTransparentFunctionComponent
33
from './isReferentiallyTransparentFunctionComponent';
44

develop/utils/createHelper.js

+29
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
import { wrapDisplayName } from 'recompose';
2+
3+
const createHelper = (
4+
func,
5+
helperName,
6+
setDisplayName = true,
7+
noArgs = false
8+
) => {
9+
if (process.env.NODE_ENV !== 'production' && setDisplayName) {
10+
if (noArgs) {
11+
return BaseComponent => {
12+
const Component = func(BaseComponent);
13+
Component.displayName = wrapDisplayName(BaseComponent, helperName);
14+
return Component;
15+
};
16+
}
17+
18+
return (...args) =>
19+
BaseComponent => {
20+
const Component = func(...args)(BaseComponent);
21+
Component.displayName = wrapDisplayName(BaseComponent, helperName);
22+
return Component;
23+
};
24+
}
25+
26+
return func;
27+
};
28+
29+
export default createHelper;

develop/utils/omit.js

-13
This file was deleted.

develop/utils/pick.js

-14
This file was deleted.

develop/utils/props2Stream.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import { Component } from 'react';
2-
import createHelper from 'recompose/createHelper';
2+
import omit from 'lodash.omit';
3+
34
import { BehaviorSubject } from 'rxjs/BehaviorSubject';
45
import 'rxjs/add/operator/distinctUntilChanged';
6+
7+
import createHelper from './createHelper';
58
import createEagerFactory from './createEagerFactory';
6-
import omit from './omit';
79

810
const prop2Stream = (propName, comparator = (a, b) => a === b) =>
911
BaseComponent => {

develop/utils/stream2Props.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Component } from 'react';
2-
import createHelper from 'recompose/createHelper';
2+
import createHelper from './createHelper';
33
import createEagerFactory from './createEagerFactory';
44

55
// if stream prop will change this will fail,

develop/utils/withStateSelector.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Component } from 'react';
2-
import createHelper from 'recompose/createHelper';
2+
import createHelper from './createHelper';
33
import createEagerFactory from './createEagerFactory';
44

55
const withStateSelector = (stateName, stateUpdaterName, selectorFactory) =>

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"jsdom": "^6.5.1",
7979
"kotatsu": "^0.14.0",
8080
"lint-staged": "^3.4.0",
81+
"lodash.omit": "^4.5.0",
8182
"mocha": "^2.3.3",
8283
"node-sass": "^3.7.0",
8384
"normalize.css": "^4.1.1",

webpack.config.base.js

+7-11
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,27 @@
1-
var webpack = require('webpack');
2-
3-
var reactExternal = {
1+
const reactExternal = {
42
root: 'React',
53
commonjs2: 'react',
64
commonjs: 'react',
7-
amd: 'react'
5+
amd: 'react',
86
};
97

10-
var reactDomExternal = {
8+
const reactDomExternal = {
119
root: 'ReactDOM',
1210
commonjs2: 'react-dom',
1311
commonjs: 'react-dom',
14-
amd: 'react-dom'
12+
amd: 'react-dom',
1513
};
1614

1715
module.exports = {
1816
output: {
1917
library: 'GoogleMapReact',
20-
libraryTarget: 'umd'
18+
libraryTarget: 'umd',
2119
},
2220
externals: {
23-
'react': reactExternal,
21+
react: reactExternal,
2422
'react-dom': reactDomExternal,
2523
},
2624
module: {
27-
loaders: [
28-
{ test: /\.js$/, exclude: /node_modules/, loader: 'babel' }
29-
]
25+
loaders: [{ test: /\.js$/, exclude: /node_modules/, loader: 'babel' }],
3026
},
3127
};

webpack.config.dev.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
var webpack = require('webpack');
2-
var baseConfig = require('./webpack.config.base');
1+
const webpack = require('webpack');
2+
const baseConfig = require('./webpack.config.base');
33

4-
var config = Object.create(baseConfig);
4+
const config = Object.create(baseConfig);
55
config.plugins = [
66
new webpack.optimize.OccurenceOrderPlugin(),
77
new webpack.DefinePlugin({
8-
'process.env.NODE_ENV': JSON.stringify('development')
9-
})
8+
'process.env.NODE_ENV': JSON.stringify('development'),
9+
}),
1010
];
1111

1212
module.exports = config;

webpack.config.prod.js

+7-8
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
1-
/* eslint-disable */
2-
var webpack = require('webpack');
3-
var baseConfig = require('./webpack.config.base');
1+
const webpack = require('webpack');
2+
const baseConfig = require('./webpack.config.base');
43

5-
var config = Object.create(baseConfig);
4+
const config = Object.create(baseConfig);
65
config.plugins = [
76
new webpack.optimize.OccurenceOrderPlugin(),
87
new webpack.DefinePlugin({
9-
'process.env.NODE_ENV': JSON.stringify('production')
8+
'process.env.NODE_ENV': JSON.stringify('production'),
109
}),
1110
new webpack.optimize.UglifyJsPlugin({
1211
compressor: {
1312
screw_ie8: true,
14-
warnings: false
15-
}
16-
})
13+
warnings: false,
14+
},
15+
}),
1716
];
1817

1918
module.exports = config;

yarn.lock

+6-2
Original file line numberDiff line numberDiff line change
@@ -3431,6 +3431,10 @@ lodash.memoize@^4.1.2:
34313431
version "4.1.2"
34323432
resolved "https://registry.yarnpkg.com/lodash.memoize/-/lodash.memoize-4.1.2.tgz#bcc6c49a42a2840ed997f323eada5ecd182e0bfe"
34333433

3434+
lodash.omit@^4.5.0:
3435+
version "4.5.0"
3436+
resolved "https://registry.yarnpkg.com/lodash.omit/-/lodash.omit-4.5.0.tgz#6eb19ae5a1ee1dd9df0b969e66ce0b7fa30b5e60"
3437+
34343438
lodash.pickby@^4.0.0:
34353439
version "4.6.0"
34363440
resolved "https://registry.yarnpkg.com/lodash.pickby/-/lodash.pickby-4.6.0.tgz#7dea21d8c18d7703a27c704c15d3b84a67e33aff"
@@ -5375,8 +5379,8 @@ typedarray@^0.0.6:
53755379
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
53765380

53775381
ua-parser-js@^0.7.9:
5378-
version "0.7.14"
5379-
resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.14.tgz#110d53fa4c3f326c121292bbeac904d2e03387ca"
5382+
version "0.7.17"
5383+
resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.17.tgz#e9ec5f9498b9ec910e7ae3ac626a805c4d09ecac"
53805384

53815385
uglify-js@~2.7.3:
53825386
version "2.7.5"

0 commit comments

Comments
 (0)