Merge pull request #120 from aaronjorbin/fix/119

Cast "1" and "0" as booleans when they are expected as booleans.

Author: aaronjorbin

src/Plugin.php

@@ -350,6 +350,13 @@ public function buildPHPConfig()
             } else if (isset($config[$setting]) && $config[$setting] === 'true') {
                 $config[$setting] = true;
             }
+
+            // also handle 1 and 0 as booleans
+            else if (isset($config[$setting]) && $config[$setting] === '0') {
+                $config[$setting] = false;
+            } else if (isset($config[$setting]) && $config[$setting] === '1') {
+                $config[$setting] = true;
+            }
         }
 
         return $config;

tests/PluginTest.php

@@ -61,6 +61,22 @@ public function testLoggingLevel(
         }
 
     }
+
+    /**
+     * Tests to ensure bools are properly converted from "1" and "0" strings
+     * 
+     * @ticket https://github.com/rollbar/rollbar-php-wordpress/issues/119
+     */
+    public function testSendMessageTraceBool(){
+        $plugin = $this->subject;
+
+        $plugin->setting( 'send_message_trace', '1' );
+        $plugin->setting( 'report_suppressed', '0' );
+        $data = $plugin->buildPHPConfig();
+
+        $this->assertTrue( $data['send_message_trace'] );
+        $this->assertFalse( $data['report_suppressed'] );
+    }
 
     public static function loggingLevelTestDataProvider()
     {