Skip to content

Commit 8ada628

Browse files
committed
update GitHub workflow to lint before testing so lint errors don't hang
1 parent 09ff2af commit 8ada628

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

.github/workflows/ci.yml

+4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ jobs:
1414
matrix:
1515
node-version: [8, 10, 12]
1616

17+
name: Test / Node ${{ matrix.node-version }}
1718
steps:
1819
- uses: actions/checkout@v2
1920
with:
@@ -27,5 +28,8 @@ jobs:
2728
- name: npm install
2829
run: npm install
2930

31+
- name: Lint
32+
run: npm run lint
33+
3034
- name: Run tests
3135
run: npm run test_ci

Makefile

+3-19
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,8 @@
11
TESTS = test/index.html
22
REPORTER = dot
33

4-
build:
5-
@npm run build
4+
build lint test test-browser test-server test_ci:
5+
@npm run $@
66
@echo ""
77

8-
test:
9-
@npm run test
10-
@echo ""
11-
12-
test-browser:
13-
@npm run test-browser
14-
@echo ""
15-
16-
test-server:
17-
@npm run test-server
18-
@echo ""
19-
20-
test_ci:
21-
@npm run test_ci
22-
@echo ""
23-
24-
.PHONY: test test_ci
8+
.PHONY: build lint test test-browser test-server test_ci

0 commit comments

Comments
 (0)