[core] Guard gInterpreterMutex in TClingClassInfo::IsEnum

vepadulano · pcanal · vepadulano · commit 25fcf69c0662 · 2022-10-18T16:16:56.000+02:00
Fixes #11515 This method leads to contention in some specific scenarios (see linked issue). Co-authored-by: Philippe Canal <pcanal@fnal.gov>
diff --git a/core/metacling/src/TClingClassInfo.cxx b/core/metacling/src/TClingClassInfo.cxx
@@ -815,6 +815,7 @@ bool TClingClassInfo::IsBase(const char *name) const
 
 bool TClingClassInfo::IsEnum(cling::Interpreter *interp, const char *name)
 {
+   R__LOCKGUARD(gInterpreterMutex);
    // Note: This is a static member function.
    TClingClassInfo info(interp, name);
    if (info.IsValid() && (info.Property() & kIsEnum)) {

Original file line number	Diff line number	Diff line change
`@@ -815,6 +815,7 @@ bool TClingClassInfo::IsBase(const char *name) const`
`815`	`815`
`816`	`816`	`bool TClingClassInfo::IsEnum(cling::Interpreter interp, const char name)`
`817`	`817`	`{`
	`818`	`+ R__LOCKGUARD(gInterpreterMutex);`
`818`	`819`	`// Note: This is a static member function.`
`819`	`820`	`TClingClassInfo info(interp, name);`
`820`	`821`	`if (info.IsValid() && (info.Property() & kIsEnum)) {`