[ntuple][NFC] Rename NTupleJoinValue_t to JoinValue_t

Since it is declared within `RNTupleJoinTable`, it is clear that this
type belongs to RNTuple from the context.

Author: enirolf

tree/ntuple/v7/inc/ROOT/RNTupleJoinTable.hxx

@@ -35,7 +35,7 @@ namespace Internal {
 // clang-format on
 class RNTupleJoinTable {
 public:
-   using NTupleJoinValue_t = std::uint64_t;
+   using JoinValue_t = std::uint64_t;
    using PartitionKey_t = std::uint64_t;
    static constexpr PartitionKey_t kDefaultPartitionKey = PartitionKey_t(-1);
 
@@ -52,12 +52,9 @@ private:
       //////////////////////////////////////////////////////////////////////////
       /// Container for the combined hashes of join field values.
       struct RCombinedJoinFieldValue {
-         std::vector<NTupleJoinValue_t> fJoinFieldValues;
+         std::vector<JoinValue_t> fJoinFieldValues;
 
-         RCombinedJoinFieldValue(const std::vector<NTupleJoinValue_t> &joinFieldValues)
-            : fJoinFieldValues(joinFieldValues)
-         {
-         }
+         RCombinedJoinFieldValue(const std::vector<JoinValue_t> &joinFieldValues) : fJoinFieldValues(joinFieldValues) {}
 
          inline bool operator==(const RCombinedJoinFieldValue &other) const
          {

tree/ntuple/v7/src/RNTupleJoinTable.cxx

@@ -16,10 +16,9 @@
 #include <ROOT/RNTupleJoinTable.hxx>
 
 namespace {
-ROOT::Experimental::Internal::RNTupleJoinTable::NTupleJoinValue_t
-CastValuePtr(void *valuePtr, std::size_t fieldValueSize)
+ROOT::Experimental::Internal::RNTupleJoinTable::JoinValue_t CastValuePtr(void *valuePtr, std::size_t fieldValueSize)
 {
-   ROOT::Experimental::Internal::RNTupleJoinTable::NTupleJoinValue_t value;
+   ROOT::Experimental::Internal::RNTupleJoinTable::JoinValue_t value;
 
    switch (fieldValueSize) {
    case 1: value = *reinterpret_cast<std::uint8_t *>(valuePtr); break;
@@ -69,7 +68,7 @@ ROOT::Experimental::Internal::RNTupleJoinTable::REntryMapping::REntryMapping(
       fields.emplace_back(std::move(field));
    }
 
-   std::vector<NTupleJoinValue_t> castJoinValues;
+   std::vector<JoinValue_t> castJoinValues;
    castJoinValues.reserve(fJoinFieldNames.size());
 
    for (unsigned i = 0; i < pageSource.GetNEntries(); ++i) {
@@ -93,7 +92,7 @@ ROOT ::Experimental::Internal::RNTupleJoinTable::REntryMapping::GetEntryIndexes(
    if (valuePtrs.size() != fJoinFieldNames.size())
       throw RException(R__FAIL("number of value pointers must match number of join fields"));
 
-   std::vector<NTupleJoinValue_t> castJoinValues;
+   std::vector<JoinValue_t> castJoinValues;
    castJoinValues.reserve(valuePtrs.size());
 
    for (unsigned i = 0; i < valuePtrs.size(); ++i) {