[VecOps] Remove outdated IsSmall helper function in tests

guitargeek · guitargeek · commit 50e5b0db25fb · 2025-11-26T15:39:48.000+01:00
The commit 2605710 changed from using the `ROOT::Detail::VecOps::` namespace explicitly for `IsSmall` to a `using` statement. However, there was also a remnant `IsSmall` function with an outdated implementation in the test file itself, which we can now remove.
diff --git a/math/vecops/test/vecops_rvec.cxx b/math/vecops/test/vecops_rvec.cxx
@@ -1493,13 +1493,6 @@ TEST(VecOps, Construct)
    EXPECT_TRUE(fourVects[2] == ref2);
 }
 
-bool IsSmall(const RVec<int> &v)
-{
-   // the first array element is right after the 3 data members of SmallVectorBase
-   return reinterpret_cast<std::uintptr_t>(v.begin()) - reinterpret_cast<std::uintptr_t>(&v) ==
-          sizeof(void *) + 2 * sizeof(int);
-}
-
 // this is a regression test for https://github.com/root-project/root/issues/6796
 TEST(VecOps, MemoryAdoptionAndClear)
 {

Original file line number	Diff line number	Diff line change
`@@ -1493,13 +1493,6 @@ TEST(VecOps, Construct)`
`1493`	`1493`	`EXPECT_TRUE(fourVects[2] == ref2);`
`1494`	`1494`	`}`
`1495`	`1495`
`1496`		`-bool IsSmall(const RVec<int> &v)`
`1497`		`-{`
`1498`		`- // the first array element is right after the 3 data members of SmallVectorBase`
`1499`		`- return reinterpret_cast<std::uintptr_t>(v.begin()) - reinterpret_cast<std::uintptr_t>(&v) ==`
`1500`		`- sizeof(void ) + 2 sizeof(int);`
`1501`		`-}`
`1502`		`-`
`1503`	`1496`	`// this is a regression test for https://github.com/root-project/root/issues/6796`
`1504`	`1497`	`TEST(VecOps, MemoryAdoptionAndClear)`
`1505`	`1498`	`{`