[RF] Replace some usage of Form with standard C++

Author: guitargeek

roofit/roofitcore/src/RooMinimizer.cxx

@@ -536,9 +536,9 @@ RooFit::OwningPtr<RooFitResult> RooMinimizer::save(const char *userName, const c
       return nullptr;
    }
 
-   TString name = userName ? userName : Form("%s", _fcn->getFunctionName().c_str());
-   TString title = userTitle ? userTitle : Form("%s", _fcn->getFunctionTitle().c_str());
-   auto fitRes = std::make_unique<RooFitResult>(name, title);
+   std::string name = userName ? std::string{userName} : _fcn->getFunctionName();
+   std::string title = userTitle ? std::string{userTitle} : _fcn->getFunctionTitle();
+   auto fitRes = std::make_unique<RooFitResult>(name.c_str(), title.c_str());
 
    fitRes->setConstParList(_fcn->constParams());
 
@@ -682,7 +682,9 @@ RooPlot *RooMinimizer::contour(RooRealVar &var1, RooRealVar &var2, double n1, do
             ycoor[npoints] = ycoor[0];
             TGraph *graph = new TGraph(npoints + 1, xcoor.data(), ycoor.data());
 
-            graph->SetName(Form("contour_%s_n%f", _fcn->getFunctionName().c_str(), n[ic]));
+            std::stringstream name;
+            name << "contour_" << _fcn->getFunctionName() << "_n" << n[ic];
+            graph->SetName(name.str().c_str());
             graph->SetLineStyle(ic + 1);
             graph->SetLineWidth(2);
             graph->SetLineColor(kBlue);

roofit/roofitcore/test/testRooDataSet.cxx

@@ -169,12 +169,15 @@ TEST(RooDataSet, ReducingData)
 
    for (int i = 0; i < 3; ++i) {
       // Check with root:
-      TH1F test_hist(Form("h%i", i), "histo", 10, massmin, massmax);
+      TH1F test_hist(("h" + std::to_string(i)).c_str(), "histo", 10, massmin, massmax);
       chi2cutval += 0.5;
 
-      TCut chi2_test_cut = Form("max(track0_chi2,track1_chi2)<%f", chi2cutval);
+      std::stringstream cutString;
+      cutString << "max(track0_chi2,track1_chi2)<" << chi2cutval;
+      TCut chi2_test_cut = cutString.str().c_str();
 
-      Long64_t drawnEvents = mytree.Draw(Form("mass>>h%i", i), chi2_test_cut /*&& mass_cut*/);
+      std::string drawString = std::string{"mass>>"} + test_hist.GetName();
+      Long64_t drawnEvents = mytree.Draw(drawString.c_str(), chi2_test_cut /*&& mass_cut*/);
       ASSERT_NE(drawnEvents, 0l);
       ASSERT_EQ(test_hist.Integral(), drawnEvents);