[core] Guard gInterpreterMutex in TClingClassInfo::IsEnum

vepadulano · pcanal · vepadulano · commit ea49eef7ec6e · 2022-10-20T22:03:26.000+02:00
Fixes #11515 This method leads to contention in some specific scenarios (see linked issue). Co-authored-by: Philippe Canal <pcanal@fnal.gov>
diff --git a/core/metacling/src/TClingClassInfo.cxx b/core/metacling/src/TClingClassInfo.cxx
@@ -813,6 +813,7 @@ bool TClingClassInfo::IsBase(const char *name) const
 
 bool TClingClassInfo::IsEnum(cling::Interpreter *interp, const char *name)
 {
+   R__LOCKGUARD(gInterpreterMutex);
    // Note: This is a static member function.
    TClingClassInfo info(interp, name);
    if (info.IsValid() && (info.Property() & kIsEnum)) {

Original file line number	Diff line number	Diff line change
`@@ -813,6 +813,7 @@ bool TClingClassInfo::IsBase(const char *name) const`
`813`	`813`
`814`	`814`	`bool TClingClassInfo::IsEnum(cling::Interpreter interp, const char name)`
`815`	`815`	`{`
	`816`	`+ R__LOCKGUARD(gInterpreterMutex);`
`816`	`817`	`// Note: This is a static member function.`
`817`	`818`	`TClingClassInfo info(interp, name);`
`818`	`819`	`if (info.IsValid() && (info.Property() & kIsEnum)) {`