silence enum -Wshadow warnings by clang #20873
Open
+469
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
commented
Jan 13, 2026
ferdymercury
requested review from
bellenot,
couet,
dpiparo,
guitargeek,
linev and
pcanal
as code owners
Member
|
Is this meant to replace/extend #20793 ? |
Collaborator
Author
Yes, it's a replacement since the other one was incorrect. |
Test Results 23 files 23 suites 3d 21h 43m 31s ⏱️ For more details on these failures, see this check. Results for commit 4c038ac. |
pcanal
reviewed
Jan 20, 2026
| kLast = BIT(20), // Take the last value | ||
| kIsConst = BIT(21) // Set if all values are equal | ||
| enum EStatusBits { | ||
| // clang++ (-Wshadow) complains about shadowing TMatrixT::EMatrixCreatorsOp2. Let's silence warning: |
Member
There was a problem hiding this comment.
I am confused. Is clang really complaining about TParameter::kMultiply shadowing TMatrixT::kMultiply?
Collaborator
Author
There was a problem hiding this comment.
Yep. At least clang 15.
It's the same issue as https://issues.chromium.org/issues/41420763#comment6
Maybe related: https://stackoverflow.com/a/53844780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes #20790
Tested locally with clang15, using: test.txt
I did not go into modifying ROOT/....hxx headers, they give more warnings/errors, so to run the example above, comment all include ROOT/...:
This test.txt script could maybe become part of the static analyzer we mentioned some time ago (based on https://github.com/olifre/rootStaticAnalyzer)
On the other hand, one could say this is all a bug in clang and the issue is a Won'tFix, since g++ does not shown these warnings. So I'm happy to close this PR, too.
Checklist: