Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

are atoms, molecules and organisms something we should put in a separate monorepo #3

Open
danalexilewis opened this issue Jul 28, 2018 · 0 comments

Comments

@danalexilewis
Copy link

when viewing the wired-elements repo I noticed they have it as a monorepo of their design components.

this appeals to me as it makes a stronger separation between ui designed elements and the functionality of the app we are building.

I see two options for how we could do this:

  1. we pull out only the atoms into mono repo
  2. we pull out the atoms, molecules and organisms into a mono repo

Trade offs for both of these are that if you want to move quickly it means you will be needing to commit code into another npm/git repo and republish it before being able to use it in your app.

A benefit of option 2. is that you will be able to develop your organisms with new atoms in one place before needing to republish. However it is coupling the composition of elements (molecules & organisms) to the elements themselves. This would make it harder to swap in different element libraries and recompose the application. eg android vs ios

Finally an important noticing is that as all of our atoms, molecules and organisms are currently placed inside the ui folder extracting them at some point will be relatively easy. This could actually be seen as one of the jobs to be done towards the end of a project post release. The first job of the code maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant