[Pid] Save i_term
instead of error integral (backport #294)
#389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal state should be the i_term to avoid jumps in the output while tuning the integral gain. Reverts #33
With constant gains, this PR does not change the current behavior of output calculation. Only the field in the published message and the result of
get_current_pid_errors
will be changed.I got confused of the message definition, because it has some duplicates:
ros-controls/control_msgs#173
If yes, let's fix that in a new PR.
This is an automatic backport of pull request #294 done by Mergify.