Skip to content

Conversation

@Juliaj
Copy link
Contributor

@Juliaj Juliaj commented Nov 21, 2025

Companion PR for ros-controls/ros2_controllers#2021

This augments example_5 to demonstrate the wrench transformer utility node for the force_torque_sensor_broadcaster.

  • use_wrench_transformer is introduced to control whether to launch the wrench transformer node, by default, it is false.

@Juliaj Juliaj changed the title [Example_5] Illustrate the usage of wrench transformer [example_5] Update demo to illustrate the usage of wrench transformer Nov 21, 2025
Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The failing tests may be a consequence of

2025-11-23T02:20:27.7426040Z 3: [ERROR] [launch]: Caught exception in launch (see debug for traceback): package 'force_torque_sensor_broadcaster' found at '/home/runner/work/ros2_control_demos/ros2_control_demos/.work/upstream_ws/install/force_torque_sensor_broadcaster', but libexec directory '/home/runner/work/ros2_control_demos/ros2_control_demos/.work/upstream_ws/install/force_torque_sensor_broadcaster/lib/force_torque_sensor_broadcaster' does not exist
2025-11-23T02:20:27.7428853Z 3: Processes under test stopped before tests completed

Let's wait for the upstream PR to be merged.


def test_wrench_transformer_node_start(self, proc_output):
"""Test that the wrench transformer node starts when use_wrench_transformer is true."""
check_node_running(self.node, "fts_wrench_transformer")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a test if the expected topic is published? Just to ensure that the documentation is in accordance with the actual behavior of the node.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using WaitForTopics?
https://docs.ros.org/en/rolling/p/launch_testing_ros/launch_testing_ros.wait_for_topics.html

It hides just the subscription inside

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new to me, thanks for pointing it out. It's indeed handy, updated the test.

@Juliaj
Copy link
Contributor Author

Juliaj commented Nov 29, 2025

The failing tests may be a consequence of

2025-11-23T02:20:27.7426040Z 3: [ERROR] [launch]: Caught exception in launch (see debug for traceback): package 'force_torque_sensor_broadcaster' found at '/home/runner/work/ros2_control_demos/ros2_control_demos/.work/upstream_ws/install/force_torque_sensor_broadcaster', but libexec directory '/home/runner/work/ros2_control_demos/ros2_control_demos/.work/upstream_ws/install/force_torque_sensor_broadcaster/lib/force_torque_sensor_broadcaster' does not exist
2025-11-23T02:20:27.7428853Z 3: Processes under test stopped before tests completed

@christophfroehlich, this test failure still persists in the latest runs. I suspect it was due to ros-rolling-force-torque-sensor-broadcaster installed in CI was still the old version. I did follow on my dev machine,

sudo apt-get install -y ros-rolling-force-torque-sensor-broadcaster

# following shows 5.8.0
dpkg -l | grep force-torque-sensor-broadcaster

The version from source main package.xml is at 6.0.0.

Let me know if further debugging is needed. Thanks a bunch!

@christophfroehlich
Copy link
Member

@christophfroehlich, this test failure still persists in the latest runs. I suspect it was due to ros-rolling-force-torque-sensor-broadcaster installed in CI was still the old version. I did follow on my dev machine,

This is expected behavior. binary build install the released packages, the rolling semi-binary build is green (compiling ros2_controller from source), kilted semi-binary is failing because we haven't merged the backports yet.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx :)

@christophfroehlich christophfroehlich merged commit 79b53d8 into ros-controls:master Dec 1, 2025
8 of 12 checks passed
@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. labels Dec 1, 2025
mergify bot pushed a commit that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants