allow custom names for main log file in ros2 launch

Signed-off-by: Tanishq Chaudhary <[email protected]>

Author: Tanishq30052002

launch/launch/launch_service.py

@@ -55,7 +55,8 @@ def __init__(
         *,
         argv: Optional[Iterable[Text]] = None,
         noninteractive: bool = False,
-        debug: bool = False
+        debug: bool = False,
+        log_file_name: str = 'launch.log'
     ) -> None:
         """
         Create a LaunchService.
@@ -67,12 +68,18 @@ def __init__(
         """
         # Setup logging and debugging.
         launch.logging.launch_config.level = logging.DEBUG if debug else logging.INFO
+        self._log_file_name = log_file_name
+        # Ensure the log file name ends with `.log`
+        if not self._log_file_name.endswith('.log'):
+            self._log_file_name += '.log'
+        launch.logging.launch_config.log_file_name = self._log_file_name
+        # Setup logging
+        self._logger_name = self._log_file_name.removesuffix('.log')
+        self.__logger = launch.logging.get_logger(self._logger_name)
+
         self.__debug = debug
         self.__argv = argv if argv is not None else []
 
-        # Setup logging
-        self.__logger = launch.logging.get_logger('launch')
-
         # Setup context and register a built-in event handler for bootstrapping.
         self.__context = LaunchContext(argv=self.__argv, noninteractive=noninteractive)
         self.__context.register_event_handler(OnIncludeLaunchDescription())

launch/launch/logging/__init__.py

@@ -113,6 +113,7 @@ def reset(self):
         self.screen_formatter = None
         self.file_formatter = None
         self._log_handler_factory = None
+        self._log_file_name = 'launch.log'
         logging.root.setLevel(logging.INFO)
         self.set_screen_format('default')
         self.set_log_format('default')
@@ -130,6 +131,20 @@ def level(self, new_level):
         """
         logging.root.setLevel(new_level)
 
+    @property
+    def log_file_name(self) -> str:
+        """Get the current log file name."""
+        return self._log_file_name
+
+    @log_file_name.setter
+    def log_file_name(self, log_file_name: str):
+        """
+        Set the name of the log file.
+
+        :param log_file_name: the name of the log file where logger output should be written.
+        """
+        self._log_file_name = log_file_name
+
     @property
     def log_dir(self):
         """Get the current log directory, generating it if necessary."""
@@ -341,13 +356,13 @@ def log_launch_config(*, logger=logging.root):
     )))
 
 
-def get_logger(name=None) -> logging.Logger:
+def get_logger(name=None, main_log_file_name = 'launch.log') -> logging.Logger:
     """Get named logger, configured to output to screen and launch main log file."""
     logger = logging.getLogger(name)
     screen_handler = launch_config.get_screen_handler()
     if screen_handler not in logger.handlers:
         logger.addHandler(screen_handler)
-    launch_log_file_handler = launch_config.get_log_file_handler()
+    launch_log_file_handler = launch_config.get_log_file_handler(main_log_file_name)
     if launch_log_file_handler not in logger.handlers:
         logger.addHandler(launch_log_file_handler)
     return logger
@@ -416,7 +431,7 @@ def _normalize_output_configuration(config):
     return normalized_config
 
 
-def get_output_loggers(process_name, output_config):
+def get_output_loggers(process_name, output_config, main_log_file_name="launch.log"):
     """
     Get the stdout and stderr output loggers for the given process name.
 
@@ -476,7 +491,7 @@ def get_output_loggers(process_name, output_config):
         # If a 'log' output is configured for this source or for
         # 'both' sources, this logger should output to launch main log file.
         if 'log' in (output_config['both'] | output_config[source]):
-            launch_log_file_handler = launch_config.get_log_file_handler()
+            launch_log_file_handler = launch_config.get_log_file_handler(main_log_file_name)
             # Add launch main log file handler if necessary.
             if launch_log_file_handler not in logger.handlers:
                 launch_log_file_handler.setFormatterFor(