remove redundant typesupport check in serialization module (#2808) (#2815)

mergify[bot] · Tanishq30052002 · web-flow · commit fe6aca3faf56 · 2025-04-15T09:38:01.000+02:00
Signed-off-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com> (cherry picked from commit f78ed95) Co-authored-by: Tanishq Chaudhary <tanishqchaudhary101010@gmail.com>
diff --git a/rclcpp/src/rclcpp/serialization.cpp b/rclcpp/src/rclcpp/serialization.cpp
@@ -36,7 +36,6 @@ SerializationBase::SerializationBase(const rosidl_message_type_support_t * type_
 void SerializationBase::serialize_message(
   const void * ros_message, SerializedMessage * serialized_message) const
 {
-  rcpputils::check_true(nullptr != type_support_, "Typesupport is nullpointer.");
   rcpputils::check_true(nullptr != ros_message, "ROS message is nullpointer.");
   rcpputils::check_true(nullptr != serialized_message, "Serialized message is nullpointer.");
 
@@ -52,7 +51,6 @@ void SerializationBase::serialize_message(
 void SerializationBase::deserialize_message(
   const SerializedMessage * serialized_message, void * ros_message) const
 {
-  rcpputils::check_true(nullptr != type_support_, "Typesupport is nullpointer.");
   rcpputils::check_true(nullptr != serialized_message, "Serialized message is nullpointer.");
   rcpputils::check_true(
     0u != serialized_message->capacity(),

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ SerializationBase::SerializationBase(const rosidl_message_type_support_t * type_`
`36`	`36`	`void SerializationBase::serialize_message(`
`37`	`37`	`const void * ros_message, SerializedMessage * serialized_message) const`
`38`	`38`	`{`
`39`		`- rcpputils::check_true(nullptr != type_support_, "Typesupport is nullpointer.");`
`40`	`39`	`rcpputils::check_true(nullptr != ros_message, "ROS message is nullpointer.");`
`41`	`40`	`rcpputils::check_true(nullptr != serialized_message, "Serialized message is nullpointer.");`
`42`	`41`
`@@ -52,7 +51,6 @@ void SerializationBase::serialize_message(`
`52`	`51`	`void SerializationBase::deserialize_message(`
`53`	`52`	`const SerializedMessage * serialized_message, void * ros_message) const`
`54`	`53`	`{`
`55`		`- rcpputils::check_true(nullptr != type_support_, "Typesupport is nullpointer.");`
`56`	`54`	`rcpputils::check_true(nullptr != serialized_message, "Serialized message is nullpointer.");`
`57`	`55`	`rcpputils::check_true(`
`58`	`56`	`0u != serialized_message->capacity(),`