Skip to content

Missing multithread synchronization in test_clock.cpp #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmachowinski opened this issue Apr 11, 2025 · 1 comment
Closed

Missing multithread synchronization in test_clock.cpp #2804

jmachowinski opened this issue Apr 11, 2025 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jmachowinski
Copy link
Collaborator

jmachowinski commented Apr 11, 2025

Operating System:

Ubuntu 22.04

ROS version or commit hash:

jazzy

RMW implementation (if applicable):

No response

RMW Configuration (if applicable):

No response

Client library (if applicable):

rclcpp

Steps to reproduce issue

The rclcpp test are unstable.
I just had a look at the test multiple_threads_wait_on_one_clock in test_clock.cpp.
At least this test is missing multithread synchronization. E.g. everything that is accessed from multiple threads
must be protected by a mutex.

Tasks:

  • Check the test suite with something like helgrind
  • Fix all issues originating from the test suite.
@pedroazeredo04
Copy link
Contributor

Hello!

I am a first time contributor, and I tried to fix this problem in this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants