Skip to content

Config::mapGetBool causes segmentation fault when value_out is nullptr #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahcorde merged 1 commit into from
Jun 5, 2025
Merged

Config::mapGetBool causes segmentation fault when value_out is nullptr #1471

ahcorde merged 1 commit into from
Jun 5, 2025

Conversation

@ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 26, 2025

Related with this issue #1469

@ahcorde
Config::mapGetBool causes segmentation fault when value_out is nullptr
3d6db74 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this May 26, 2025
@ahcorde ahcorde mentioned this pull request May 26, 2025
Closed
@ahcorde
Copy link
Contributor Author

ahcorde commented May 26, 2025

Pulls: #1471
Gist: https://gist.githubusercontent.com/ahcorde/ab741e1c7a772886e94b0d6d2cf6215d/raw/c4305122fec8a274ceba1fefe9a329377395df80/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_common
TEST args: --packages-above rviz_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16083

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde requested a review from mjcarroll May 27, 2025 10:52
@ahcorde ahcorde merged commit 72813d1 into rolling Jun 5, 2025
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/issue_1469 branch June 5, 2025 20:01
@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 5, 2025

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2025 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jun 5, 2025
@ahcorde @mergify
Config::mapGetBool causes segmentation fault when value_out is nullptr (
1ff3763 
#1471)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 72813d1)
@mergify mergify bot mentioned this pull request Jun 5, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jun 5, 2025
@ahcorde @mergify
Config::mapGetBool causes segmentation fault when value_out is nullptr (
d84b055 
#1471)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 72813d1)
mergify bot pushed a commit that referenced this pull request Jun 5, 2025
@ahcorde @mergify
Config::mapGetBool causes segmentation fault when value_out is nullptr (
8e1ec67 
#1471)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 72813d1)
This was referenced Jun 5, 2025
Merged
Merged
ahcorde added a commit that referenced this pull request Jun 6, 2025
@mergify @ahcorde
Config::mapGetBool causes segmentation fault when value_out is nullptr (
3a58bd9 
#1471) (#1479)

(cherry picked from commit 72813d1)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
ahcorde added a commit that referenced this pull request Jun 6, 2025
@mergify @ahcorde
Config::mapGetBool causes segmentation fault when value_out is nullptr (
750d23f 
#1471) (#1480)

(cherry picked from commit 72813d1)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
ahcorde added a commit that referenced this pull request Jun 6, 2025
@mergify @ahcorde
Config::mapGetBool causes segmentation fault when value_out is nullptr (
621d342 
#1471) (#1481)

(cherry picked from commit 72813d1)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloretz sloretz sloretz approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @sloretz