feat: add Firo network support by reubenyap · Pull Request #16 · rosen-bridge/ui

reubenyap · 2026-04-04T16:27:08Z

Summary

This PR adds complete Firo chain integration to the Rosen Bridge UI, following the established UTXO chain pattern used by Doge and Bitcoin.

Note: This PR supersedes #15 and incorporates all of its changes along with fixes for the review feedback raised there.

Commits

The PR is structured as focused commits for easy review:

feat: add Firo network support - The full Firo integration (equivalent to the changes in add firo support #15)
fix: address review feedback on Firo integration - Fixes for the issues identified in the add firo support #15 review
Use Firo RPC for wallet utilities - Replaces unavailable BlockCypher/explorer wallet calls with Firo node RPC

Changes

Firo Integration

networks/firo/: Network package with client class, constants, types, UTXO selection, transaction generation, and Firo RPC utilities
wallets/firo-wallet/: Wallet package with browser extension integration (connect, sign, broadcast)
apps/rosen/: App wiring with server actions, lock address config, and wallet registration
packages/constants: Add Firo to NETWORKS (index 7, native token: firo)
packages/icons: Add Firo network SVG icon
packages/utils: Add Firo explorer URLs (address, token, tx)
apps/rosen-service: Gracefully skip unconfigured chains in commitment extractor registration
apps/rosen/.env.example: Add FIRO_RPC_API variable

Review Fixes

Addresses the feedback from #15 and #16:

build.sh: Add networks/firo and wallets/firo-wallet workspaces to the build script
firo.svg: Remove XML declaration and unnecessary attributes; keep only viewBox and xmlns consistent with other network SVGs
getMaxTransfer.ts: Fix typo opRetrunDataLength -> opReturnDataLength
utils.ts: Fix incorrect JSDoc @param references
Replace FIRO_BLOCKCYPHER_API / FIRO_EXPLORER_API with FIRO_RPC_API
Use Firo node RPC for UTXOs, balance, raw tx lookup, fee estimates, chain height, and tx broadcast
Expect the configured node to enable address and transaction indexes for getaddressutxos, getaddressbalance, and getrawtransaction
Strip Firo special-transaction extra payloads from getrawtransaction results only for PSBT nonWitnessUtxo compatibility with bitcoinjs-lib

Add complete Firo chain integration following the established UTXO chain pattern (Doge/Bitcoin): - networks/firo: Network package with client, constants, types, UTXO selection, transaction generation, and BlockCypher API utilities - wallets/firo-wallet: Wallet package with browser extension integration (connect, sign, broadcast) - apps/rosen: App wiring with server actions, lock address config, and wallet registration - packages/constants: Add Firo to NETWORKS (index 7, native token: firo) - packages/icons: Add Firo network SVG icon - packages/utils: Add Firo explorer URLs (address, token, tx) - apps/rosen-service: Gracefully skip unconfigured chains in commitment extractor registration Co-authored-by: Reuben Yap <reuben@firo.org>

@param

- Add networks/firo and wallets/firo-wallet to build.sh (BEK requirement) - Clean up firo.svg: remove XML declaration and unnecessary attributes, keep only viewBox and xmlns (consistent with other network SVGs) - Fix typo: opRetrunDataLength -> opReturnDataLength in getMaxTransfer.ts - Fix incorrect JSDoc @param references in utils.ts Co-authored-by: Reuben Yap <reuben@firo.org>

vercel · 2026-04-04T16:27:16Z

@cursoragent is attempting to deploy a commit to the rosen-bridge Team on Vercel.

A member of the Team first needs to authorize it.

Co-authored-by: Reuben Yap <reuben@firo.org>

ChainChoices (derived from NETWORKS_KEYS) includes chains like firo that have no entry in the Chains config type nor a data adapter. Using the broader ChainChoices type to index configs.chains / drive the adapter switch made the switch non-exhaustive and caused type-check failures. Narrow the index cast in assetAggregator and the parameter of createChainSpecificDataAdapter to keyof Chains so indexing is valid and the switch is exhaustive, eliminating the inferred undefined in the return type. https://claude.ai/code/session_01MJPsWRuNaJm3GSREcoMDJ5

…79-2154

- Align FiroWallet.performConnect with MyDogeWallet and other sibling wallets by calling this.isConnected() (base-class wrapper that asserts availability and swallows connection-check errors) instead of the raw hasConnection() vendor probe. - Add a changeset covering the full Firo integration plus the rosen-service2 type-narrowing fix so the changeset CI check passes. https://claude.ai/code/session_01MJPsWRuNaJm3GSREcoMDJ5

This reverts commit e561b34.

`path.posix.relative` cannot produce a correct relative path from two Windows-absolute paths, so `getKnipCommand` was emitting garbage like `knip --dependencies --workspace ../E:\Github\rosen-ui\packages\X`, which knip rejects as "Workspace is not a directory". This blocked pre-commit hooks on Windows for any commit touching package sources. Use the cross-platform `path.relative` and normalize separators to forward slashes (matching the existing type-check line that already uses `path.relative`).

With firo in NETWORKS_KEYS but not yet in configs.chains, ChainChoices is wider than keyof typeof configs.chains. Adjust the two spots that index configs.chains[chain] so tsc stays green until the backend Firo config lands: - assetAggregator: cast chain to keyof typeof configs.chains at the index site. - assetDataAdapters: narrow createChainSpecificDataAdapter's chain parameter from ChainChoices to keyof typeof configs.chains (the switch never handled firo anyway), removing the now-unused ChainChoices import.

cursoragent and others added 2 commits April 4, 2026 16:23

reubenyap mentioned this pull request Apr 4, 2026

add firo support #15

Closed

abdolian approved these changes Apr 4, 2026

View reviewed changes

vorujack previously approved these changes Apr 16, 2026

View reviewed changes

RaaCT0R previously approved these changes Apr 16, 2026

View reviewed changes

fix(firo): remove unused tsx devDependency

ed5812b

Co-authored-by: Reuben Yap <reuben@firo.org>

cursor Bot dismissed stale reviews from RaaCT0R and vorujack via ed5812b April 16, 2026 07:13

vorujack previously approved these changes Apr 16, 2026

View reviewed changes

reubenyap dismissed vorujack’s stale review via e561b34 April 17, 2026 09:56

reubenyap and others added 2 commits April 17, 2026 18:02

Merge branch 'dev' into cursor/-bc-2b025ca2-9368-47a2-ac62-6845cce1b4…

3ff5f09

…79-2154

reubenyap requested review from RaaCT0R, abdolian and vorujack April 17, 2026 18:20

vorujack previously approved these changes Apr 18, 2026

View reviewed changes

RaaCT0R previously approved these changes Apr 18, 2026

View reviewed changes

abdolian reviewed Apr 18, 2026

View reviewed changes

Comment thread apps/rosen-service2/src/services/assetAggregator.ts

Comment thread .changeset/firo-network-support.md Outdated

reubenyap added 2 commits April 19, 2026 18:12

Revert "fix(rosen-service2): narrow chain types to exclude firo"

9a596cf

This reverts commit e561b34.

chore(changeset): split firo-network-support into per-package entries

5c28730

reubenyap dismissed stale reviews from RaaCT0R and vorujack via 5c28730 April 19, 2026 10:38

abdolian approved these changes Apr 19, 2026

View reviewed changes

vorujack previously approved these changes Apr 19, 2026

View reviewed changes

reubenyap added 2 commits April 21, 2026 07:45

reubenyap dismissed vorujack’s stale review via 8da43ef April 20, 2026 23:45

This was referenced Apr 22, 2026

feat(rosen-service): add Firo chain integration #19

Open

feat: add Firo chain support to asset-calculator #18

Closed

vorujack previously approved these changes Apr 25, 2026

View reviewed changes

RaaCT0R requested changes Apr 26, 2026

View reviewed changes

Comment thread networks/firo/src/utils.ts Outdated

Merge dev into Firo support PR

f7319c5

reubenyap dismissed vorujack’s stale review via f7319c5 April 29, 2026 11:18

Use Firo RPC for wallet utilities

0f0cf6c

reubenyap force-pushed the cursor/-bc-2b025ca2-9368-47a2-ac62-6845cce1b479-2154 branch from cdd7b09 to 0f0cf6c Compare April 29, 2026 12:22

chore: make prettier line endings portable

9c02000

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Firo network support#16

feat: add Firo network support#16
reubenyap wants to merge 13 commits intorosen-bridge:devfrom
reubenyap:cursor/-bc-2b025ca2-9368-47a2-ac62-6845cce1b479-2154

reubenyap commented Apr 4, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Apr 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

reubenyap commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Commits

Changes

Firo Integration

Review Fixes

Uh oh!

vercel Bot commented Apr 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

reubenyap commented Apr 4, 2026 •

edited

Loading