Conversation
Summary of ChangesHello @hkfires, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the ID token claims by incorporating subscription start and end dates for ChatGPT. This change provides richer user authentication information, enabling services to more accurately determine a user's active subscription period directly from their ID token, which can be crucial for access control and feature provisioning. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds two new subscription date fields, chatgpt_subscription_active_start and chatgpt_subscription_active_until, to the extracted Codex ID token claims. The implementation is correct, but I've added one suggestion to refactor the code to reduce duplication and improve maintainability.
| if v := claims.CodexAuthInfo.ChatgptSubscriptionActiveStart; v != nil { | ||
| result["chatgpt_subscription_active_start"] = v | ||
| } | ||
| if v := claims.CodexAuthInfo.ChatgptSubscriptionActiveUntil; v != nil { | ||
| result["chatgpt_subscription_active_until"] = v | ||
| } |
There was a problem hiding this comment.
To reduce code repetition and improve maintainability, you could use a map and a loop to add these claims to the result. This approach is more scalable if more claims need to be added in the future.
for key, value := range map[string]any{
"chatgpt_subscription_active_start": claims.CodexAuthInfo.ChatgptSubscriptionActiveStart,
"chatgpt_subscription_active_until": claims.CodexAuthInfo.ChatgptSubscriptionActiveUntil,
} {
if value != nil {
result[key] = value
}
}
feat(codex): add subscription date fields to ID token claims
feat(codex): add subscription date fields to ID token claims
2 participants
No description provided.