Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrows could suffer from CLJ-1121 #25

Open
AlexKnauth opened this issue Jul 11, 2014 · 1 comment
Open

Arrows could suffer from CLJ-1121 #25

AlexKnauth opened this issue Jul 11, 2014 · 1 comment

Comments

@AlexKnauth
Copy link

See http://dev.clojure.org/jira/browse/CLJ-1121
It gives this example:
After

(macroexpand-1 (macroexpand-1 '(-> a b c)))

=> (c (-> a b))

c is now in control if it is a macro, and is now seeing the argument (-> a b) rather than (b a) as would be the case if we had written (c (b a)) originally.
CLJ-1121 says it's fixed now, but it looks like maybe -<> and -<>> (and maybe the other ones) could suffer from the same problem.
I haven't actually tried it because I'm not actually a clojure user (I use racket).

@rplevy
Copy link
Owner

rplevy commented Jul 11, 2014

Thanks for bringing my attention to this. Personally, I'm not too worried about it as this is a theoretical edge case that I don't see as any having any practical importance, but if someone thinks otherwise and wants to submit a pull request, there's nothing wrong with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants