Skip to content

Commit a4b5f1c

Browse files
committed
Minor update to comments
1 parent 6556a15 commit a4b5f1c

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

graphics-by-opengl-j2se/src/main/java/com/nucleus/GraphicsPipeline.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public void glVertexAttribPointer(ArrayList<Attributes> attribs,
7474
* Uploads one of more float variables to the render API, supports VEC2, VEC3, VEC4 and MAT2, MAT3,
7575
* MAT4 types
7676
*
77-
* @param Buffer containing data to be uploaded
77+
* @param data containing data to be uploaded
7878
* @param variable Shader variable to set data for, datatype and size is read. If null then nothing is done
7979
*/
8080
public void uploadVariable(FloatBuffer data, ShaderVariable variable);
@@ -84,7 +84,7 @@ public void glVertexAttribPointer(ArrayList<Attributes> attribs,
8484
*
8585
*
8686
* @param uniformData The uniform source data
87-
* @param activeUniforms The active uniforms to upload, null to set all active uniforms.
87+
* @param activeUniform The active uniforms to upload, null to set all active uniforms.
8888
* @throws BackendException
8989
*/
9090
public void uploadUniforms(FloatBuffer uniformData, ShaderVariable[] activeUniform) throws BackendException;

graphics-by-opengl-j2se/src/main/java/com/nucleus/Pipeline.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.nucleus.renderer.NucleusRenderer.Renderers;
77
import com.nucleus.scene.gltf.GLTF;
88
import com.nucleus.scene.gltf.Primitive;
9+
import com.nucleus.shader.GraphicsShader;
910
import com.nucleus.shader.Shader;
1011
import com.nucleus.shader.Shader.Categorizer;
1112
import com.nucleus.shader.Shader.ShaderType;
@@ -26,7 +27,7 @@
2627
public interface Pipeline<T extends Shader, S extends ShaderBinary> {
2728

2829
/**
29-
* Internal method - do not use directly - call {@link Assets#getGraphicsPipeline(NucleusRenderer, Shader)} instead
30+
* Internal method - do not use directly - call {@link Assets#getGraphicsPipeline(NucleusRenderer, GraphicsShader)} instead
3031
*
3132
* Compile and links the pipeline.
3233
* This method shall only be called once, it is an error to re-compile an already compiled pipeline.

graphics-by-opengl-j2se/src/main/java/com/nucleus/opengl/shader/GLTFShaderProgram.java

+6-2
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,11 @@ public void updatePBRUniforms(Primitive primitive) throws GLException {
184184
* This shall set texture parameters to used textures, ie activate texture, bind texture then set parameters.
185185
*
186186
* @param renderer
187-
* @param texture
187+
* @param gltf
188+
* @param primitive
189+
* @param attribute
190+
* @param texUniform
191+
* @param texInfo
188192
* @throws BackendException
189193
*/
190194
public void prepareTexture(NucleusRenderer renderer, GLTF gltf, Primitive primitive, NamedShaderVariable attribute,
@@ -204,7 +208,7 @@ public void prepareTexture(NucleusRenderer renderer, GLTF gltf, Primitive primit
204208
/**
205209
* Prepares the textures needed for this primitive
206210
*
207-
* @param gles
211+
* @param renderer
208212
* @param gltf
209213
* @param material
210214
* @throws BackendException

graphics-by-opengl-j2se/src/main/java/com/nucleus/shader/Shader.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public String getCategory() {
5555
* (vertex/fragment/compute) Default behavior is to return getPath() /
5656
* getPassString() + getShadingString()
5757
*
58-
* @param shaderType The shader type to return source for
58+
* @param type The shader type to return source for
5959
* @return
6060
*/
6161
public String getShaderSourceName(ShaderType type) {
@@ -82,7 +82,6 @@ public void addLibNames(ShaderType type, String[] libnames) {
8282
* shader (type) source. This is for shading languages that does not support
8383
* precompiler include.
8484
*
85-
* @param backend
8685
* @param type
8786
* @return Optional strings to additional library sources that shall be
8887
* included, or null
@@ -113,7 +112,7 @@ public String getCategoryString() {
113112
* Returns the relative path - by default this is the category
114113
* The path is ends with directory separator.
115114
*
116-
* @param shaderType The shader type to return source for
115+
* @param type The shader type to return source for
117116
* @return The relative path, if defined it must end with the path separator
118117
* char
119118
*/

0 commit comments

Comments
 (0)