Fixes codeql issues

Author: jeremy-then

tests/00_00_06-key_control_initial_federation.js

@@ -1,6 +1,6 @@
 const fedAssertions = require('../lib/assertions/fed');
 
-var fedAssert;
+let fedAssert;
 
 const INITIAL_FEDERATION_SIZE = 3;
 

tests/01_03_54-coinbase_information.js

@@ -8,11 +8,9 @@ const { getBtcClient } = require('../lib/btc-client-provider');
 const btcEthUnitConverter = require('@rsksmart/btc-eth-unit-converter');
 const { getRskTransactionHelpers } = require('../lib/rsk-tx-helper-provider');
 
-const { getLogger } = require('../logger');
 
 describe('Calling coinbase information methods', () => {
 
-    const logger = getLogger();
     let btcClient;
     let rskTxHelper;
     let rskTxHelpers;

tests/01_04_52-user_call.js

@@ -10,6 +10,11 @@ const CustomError = require('../lib/CustomError');
 const NETWORK = bitcoin.networks.testnet;
 
 describe('Calling registerFastBridgeBtcTransaction', function() {
+
+    let rskClient;
+    let btcClient;
+    let pegClient;
+    let utils;
 
     before(() => {
       rskClient = rsk.getClient(Runners.hosts.federate.host);

tests/01_05_52-pegout_batching_first_requests.js

@@ -4,13 +4,18 @@ const CustomError = require('../lib/CustomError');
 const _2wpUtilsLegacy = require('../lib/2wp-utils-legacy');
 const pegAssertions = require('../lib/assertions/2wp');
 
-let pegoutCount = 0;
 
 // TODO: Refactor these tests
 // Some tests fail after running all tests with all forks active from scratch.
 // More analysis need to be done. Also, these tests use legacy functions. We need to refactor them.
 describe.skip('Pegout Batching - New Pegout Requests Then Call new bridge methods', function () {
 
+    let pegoutCount = 0;
+    let rskClient;
+    let btcClient;
+    let pegClient;
+    let assertCallToBridgeMethodsRunner;
+
     before(() => {
         rskClient = rsk.getClient(Runners.hosts.federate.host);
         btcClient = bitcoin.getClient(

tests/01_05_53-pegout_batching_second_requests.js

@@ -11,16 +11,21 @@ const { NUMBER_OF_BLOCKS_BTW_PEGOUTS } = require('../lib/constants/pegout-consta
 const rskUtils = require('../lib/rsk-utils');
 const { getRskTransactionHelpers } = require('../lib/rsk-tx-helper-provider');
 
-let pegoutCount = 0;
-let currentBlockNumber;
-let assertCallToBridgeMethodsRunner;
-let rskTxHelpers;
 
 // TODO: Refactor these tests
 // Some tests fail after running all tests with all forks active from scratch.
 // More analysis need to be done. Also, these tests use legacy functions. We need to refactor them.
 describe.skip('Pegout Batching - Execute Pegout Transaction And Call New Bridge Methods', function () {
 
+    let pegoutCount = 0;
+    let currentBlockNumber;
+    let assertCallToBridgeMethodsRunner;
+    let rskClients;
+    let rskClient;
+    let btcClient;
+    let pegClient;
+    let rskTxHelpers;
+
     before(() => {
         rskClients = Runners.hosts.federates.map(federate => rsk.getClient(federate.host));
         rskClient = rsk.getClient(Runners.hosts.federate.host);

tests/01_05_55-pegout_batching_fourth_requests.js

@@ -9,18 +9,19 @@ const _2wpUtilsLegacy = require('../lib/2wp-utils-legacy');
 const pegAssertions = require('../lib/assertions/2wp');
 const { NUMBER_OF_BLOCKS_BTW_PEGOUTS } = require('../lib/constants/pegout-constants');
 
-let currentBlockNumber;
-let pegoutCount = 0;
-let rskClients;
-let rskClient;
-let btcClient;
-let pegClient;
-
 // TODO: Refactor these tests
 // Some tests fail after running all tests with all forks active from scratch.
 // More analysis need to be done. Also, these tests use legacy functions. We need to refactor them.
 describe.skip('Pegout Batching - New Pegout Requests Then Call new bridge methods', function () {
 
+    let currentBlockNumber;
+    let pegoutCount = 0;
+    let rskClients;
+    let rskClient;
+    let btcClient;
+    let pegClient;
+    let assertCallToBridgeMethodsRunner;
+
     before(() => {
         rskClients = Runners.hosts.federates.map(federate => rsk.getClient(federate.host));
         rskClient = rsk.getClient(Runners.hosts.federate.host);

tests/01_05_56-pegout_batching_advance_blockchain.js

@@ -6,13 +6,15 @@ const { NUMBER_OF_BLOCKS_BTW_PEGOUTS } = require('../lib/constants/pegout-consta
 const rskUtils = require('../lib/rsk-utils');
 const { getRskTransactionHelpers } = require('../lib/rsk-tx-helper-provider');
 
-let rskTxHelpers;
-
 // TODO: Refactor these tests
 // Some tests fail after running all tests with all forks active from scratch.
 // More analysis need to be done. Also, these tests use legacy functions. We need to refactor them.
 describe.skip('Pegout Batching - Advance the blockchain until the next pegout creation height (no pegout requests).', function () {
 
+    let rskTxHelpers;
+    let rskClient;
+    let assertCallToBridgeMethodsRunner;
+
     before(() => {
         rskClient = rsk.getClient(Runners.hosts.federate.host);
         assertCallToBridgeMethodsRunner = pegAssertions.assertCallToPegoutBatchingBridgeMethods(rskClient);