Skip to content

Commit 9d4b6bf

Browse files
Darhazerbackus
authored andcommitted
Refactor NamedSubject to use Language module (#447)
1 parent 1f4dd67 commit 9d4b6bf

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

lib/rubocop/cop/rspec/named_subject.rb

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,10 @@ class NamedSubject < Cop
4242
'to reference it explicitly.'.freeze
4343

4444
def_node_matcher :rspec_block?, <<-PATTERN
45-
(block
46-
(send nil {:it :specify :before :after :around} ...)
47-
...)
45+
{
46+
#{Examples::ALL.block_pattern}
47+
#{Hooks::ALL.block_pattern}
48+
}
4849
PATTERN
4950

5051
def_node_matcher :unnamed_subject, '$(send nil :subject)'
@@ -60,11 +61,9 @@ def on_block(node)
6061
private
6162

6263
def subject_usage(node, &block)
63-
return unless node.is_a?(Parser::AST::Node)
64-
6564
unnamed_subject(node, &block)
6665

67-
node.children.each do |child|
66+
node.each_child_node do |child|
6867
subject_usage(child, &block)
6968
end
7069
end

0 commit comments

Comments
 (0)