Skip to content

Fix getting_started page #80 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hozaka wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix getting_started page #80 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d6f84
Split contributors link
hozaka Mar 18, 2014
3fef27a
Fix the rendering issue on page getting_started
hozaka Mar 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions rails_guides/helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ def guide(name, url, options = {}, &block)
result = content_tag(:dt, link)
result <<
if options[:work_in_progress]
content_tag(:dd, "施工中！贡献者: <a href='http://github.com/#{options[:contributor]}'>#{options[:contributor] || '匿名'}</a>".html_safe, :class => 'work-in-progress')
content_tag(:dd, "施工中！贡献者: #{generate_contributors_link(options[:contributor])}".html_safe, :class => 'work-in-progress')
elsif !options[:contributor]
content_tag(:dd, :class => 'work-in-progress' ) do
"这篇还没有人翻译，我要<a href='https://github.com/ruby-china/rails-guides'>翻译本文</a>".html_safe
end
else
content_tag(:dd, :class => 'contributor' ) do
"贡献者：<a href='http://github.com/#{options[:contributor]}'>#{options[:contributor] || '匿名'}</a>".html_safe
"贡献者：#{generate_contributors_link(options[:contributor])}".html_safe
end
end
result << content_tag(:dd, capture(&block))
Expand Down Expand Up @@ -49,5 +49,16 @@ def code(&block)
c = capture(&block)
content_tag(:code, c)
end

private
def generate_contributors_link(contributors_string = '')
result = []
contributors = contributors_string.split(/\,\s/)
contributors.each do |name|
result << content_tag('a', name, :href => "https://github.com/#{name}")
end

return result.join(', ')
end
end
end
Loading