Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GOPATH with ':' in it #8

Open
rubyist opened this issue Apr 7, 2014 · 4 comments
Open

Handle GOPATH with ':' in it #8

rubyist opened this issue Apr 7, 2014 · 4 comments
Labels

Comments

@rubyist
Copy link
Owner

rubyist commented Apr 7, 2014

The GOPATH environment variable can be a : separated list of paths. Properly handle when this is the case.

@rubyist rubyist added the bug label Apr 7, 2014
@joefitzgerald
Copy link

@rubyist
Copy link
Owner Author

rubyist commented Apr 8, 2014

Cool. I saw your tweet the other day about pulling go-oracle into go-plus - I was thinking you might not be down with oracle being an external dependency that needs separate installation, but if that doesn't bother you then it might be worthwhile to merge efforts. I'm liking the idea of a single go package (outside of language-go, that is). It's also nice that we won't have to duplicate this kind of code.

I'll work up a PR in the next couple of days and see what you think.

@joefitzgerald
Copy link

Yeah, I already have goimports and golint as external dependencies which require installation. For now, I just leave that functionality disabled by default, and default the configuration for the path preference to: $GOPATH/bin/<toolname> e.g. $GOPATH/bin/golint

I noticed you were doing lots of work on the display panel, and I recently took a dependency on atom-message-panel. I'm guessing that oracle might require new view(s), and they'll be similar to the view(s) I'll need to create for godoc support. But the good news is they are pluggable and we can benefit from the core functionality provided by the panel.

I'm all for merging if you're good with it. After all, go-plus is based on the work you started :) I'd also point out you are a contributor on the repo, so you can directly commit if you'd like.

@binary132
Copy link

Bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants