Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit 9e3bf90

Browse files
committed
Merge branch '6.0'
2 parents c1fb4ee + b9aafdf commit 9e3bf90

12 files changed

+23
-23
lines changed

CHANGELOG.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
### v5.9.211.38.0beta1 - Unreleased
1+
### v6.0.286.54.0 - Unreleased
22

3-
* Update upstream v8 version to 6.0.286.44
3+
* Update upstream v8 version to 6.0.286.54
44
* V8 source is no longer pulled using the fetch command from depot_tools but is
55
instead added as a submodule in the current tree
66
* Hooks are no longer ran after syncing V8's upstream dependencies
7+
* Reordered libraries in accordance with the V8 wiki
8+
* Added groups around the library flags in accordance with the V8 wiki
79

810
### v5.9.211.38.0, v5.9.211.38.1 - 2017-07-26
911

ext/libv8/location.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def install!
2929

3030
def configure(context = MkmfContext.new)
3131
context.incflags.insert 0, Libv8::Paths.include_paths.map{ |p| "-I#{p}" }.join(" ") + " "
32-
context.ldflags.insert 0, Libv8::Paths.object_paths.join(" ") + " "
32+
context.ldflags.insert 0, "-Wl,--start-group " + Libv8::Paths.object_paths.join(" ") + " -Wl,--end-group "
3333
end
3434

3535
def verify_installation!

ext/libv8/paths.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def include_paths
1111
end
1212

1313
def object_paths
14-
[:base, :libplatform, :libsampler, :libbase, :snapshot].map do |name|
14+
[:base, :libbase, :snapshot, :libplatform, :libsampler].map do |name|
1515
Shellwords.escape libv8_object(name)
1616
end
1717
end

lib/libv8/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module Libv8
2-
VERSION = "6.0.286.44.0beta1"
2+
VERSION = "6.0.286.54.0beta1"
33
end

patches/0001-Build-a-standalone-static-library.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
From b3d75137651a41d141c29c55725bc97485b247d8 Mon Sep 17 00:00:00 2001
1+
From 6c28fb0319c5e2e7afad4b5731fc0ded86e1f7e7 Mon Sep 17 00:00:00 2001
22
From: Petko Bordjukov <[email protected]>
33
Date: Mon, 25 Jul 2016 00:00:19 +0300
44
Subject: [PATCH 1/5] Build a standalone static library

patches/0002-Don-t-compile-unnecessary-stuff.patch

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
From 45000acd2fe5ccf48d1061f76eea2333524ebe74 Mon Sep 17 00:00:00 2001
1+
From 31d199f67ff88be5576869abcc23ecf219fa1e6f Mon Sep 17 00:00:00 2001
22
From: Petko Bordjukov <[email protected]>
3-
Date: Tue, 28 Feb 2017 00:04:26 +0200
3+
Date: Fri, 28 Jul 2017 11:11:08 +0300
44
Subject: [PATCH 2/5] Don't compile unnecessary stuff
55

66
---
7-
Makefile | 14 ++++----------
7+
Makefile | 12 +++---------
88
gypfiles/all.gyp | 33 ---------------------------------
9-
2 files changed, 4 insertions(+), 43 deletions(-)
9+
2 files changed, 3 insertions(+), 42 deletions(-)
1010

1111
diff --git a/Makefile b/Makefile
12-
index ed5b3a7fab..360dc3a1a1 100644
12+
index ed5b3a7fab..04eddb5e8a 100644
1313
--- a/Makefile
1414
+++ b/Makefile
15-
@@ -265,16 +265,10 @@ ANDROID_ARCHES = android_ia32 android_x64 android_arm android_arm64 \
15+
@@ -265,15 +265,9 @@ ANDROID_ARCHES = android_ia32 android_x64 android_arm android_arm64 \
1616
android_mipsel android_x87
1717

1818
# List of files that trigger Makefile regeneration:
@@ -25,14 +25,12 @@ index ed5b3a7fab..360dc3a1a1 100644
2525
- tools/parser-shell.gyp testing/gmock.gyp testing/gtest.gyp \
2626
- buildtools/third_party/libc++abi/libc++abi.gyp \
2727
- buildtools/third_party/libc++/libc++.gyp samples/samples.gyp \
28-
- src/third_party/vtune/v8vtune.gyp src/d8.gyp
2928
+GYPFILES = gypfiles/shim_headers.gypi gypfiles/features.gypi \
30-
+ gypfiles/standalone.gypi gypfiles/toolchain.gypi \
31-
+ gypfiles/all.gyp gypfiles/mac/asan.gyp \
32-
+ tools/parser-shell.gyp src/d8.gyp
29+
+ gypfiles/standalone.gypi gypfiles/all.gyp \
30+
+ gypfiles/mac/asan.gyp src/v8.gyp tools/parser-shell.gyp \
31+
src/third_party/vtune/v8vtune.gyp src/d8.gyp
3332

3433
# If vtunejit=on, the v8vtune.gyp will be appended.
35-
ifeq ($(vtunejit), on)
3634
diff --git a/gypfiles/all.gyp b/gypfiles/all.gyp
3735
index bc9d9650eb..96820a0ecc 100644
3836
--- a/gypfiles/all.gyp

patches/0003-Use-the-fPIC-flag-for-the-static-library.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
From 185c0249653dafb4ae20d21f2a0cc241c3e96c64 Mon Sep 17 00:00:00 2001
1+
From fe76837b00357250a01ad71c4cce4b7524dd765f Mon Sep 17 00:00:00 2001
22
From: Petko Bordjukov <[email protected]>
33
Date: Mon, 25 Jul 2016 00:05:47 +0300
44
Subject: [PATCH 3/5] Use the -fPIC flag for the static library

patches/0004-Do-not-embed-debug-symbols-in-macOS-libraries.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
From 596e88c9c1a158abc878bd81112aa9b5ec38033a Mon Sep 17 00:00:00 2001
1+
From 7b00cf7c2c13d4c528bccd3bc4a91426f4e35145 Mon Sep 17 00:00:00 2001
22
From: Jb Aviat <[email protected]>
33
Date: Mon, 27 Feb 2017 11:14:42 +0200
44
Subject: [PATCH 4/5] Do not embed debug symbols in macOS libraries

patches/0005-Fix-GCC-7-build-errors.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
From da4cfa16ed1cbbc5e2ecfeecb64cbe939029ff36 Mon Sep 17 00:00:00 2001
1+
From a8f772b3a6bcfad871b4d09935727032faf84df2 Mon Sep 17 00:00:00 2001
22
From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <[email protected]>
33
Date: Tue, 20 Jun 2017 13:14:38 +0200
44
Subject: [PATCH 5/5] Fix GCC 7 build errors

spec/location_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
end
6565

6666
it "prepends the locations of any libv8 objects on the the ldflags" do
67-
expect(@context.ldflags).to eql "/foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_base.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libplatform.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libsampler.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libbase.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_snapshot.a -lobjc -lpthread"
67+
expect(@context.ldflags).to eql "-Wl,--start-group /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_base.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libbase.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_snapshot.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libplatform.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libsampler.a -Wl,--end-group -lobjc -lpthread"
6868
end
6969
end
7070
end

0 commit comments

Comments
 (0)