-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The main page is _just a little bit_ too tall, maybe? #237
Comments
170 extra, possibly unnecessary, pixels of margins. |
It's a bit hard to say how tall the content actually is now. On an OS without any relevant links. the only buttons shown are "Website Package" and "Other Downloads", taking up just one line on a wide screen. On most OS's and browsers, the links instead take up 2-3 lines on a wide screen (3 lines as in the screenshot above, and 2 lines on most Windows and Mac computers or on an unsupported browser on Linux). We can edit any of these three files, but screen sizes and window borders also vary a lot.
ruffle-rs.github.io/src/app/index.module.css Lines 30 to 33 in 170f45a
And tbh the biggest issue may be once we support i18n, the translations could end up making the page taller or shorter depending on the chosen language, and we can't monitor the size for every language. |
This is highly subjective, but I think it would be nice if the main landing page would be entirely visible without scrolling on a 1080p display, in a maximized window, including any title/status/tool/task/panel bars, etc.
I think, for this, it would have to be just a little bit shorter, like ~900px tall, instead of the current ~960.
Tweaking some margins and paddings and spacings and sizes here and there should probably get us there easily.
I am not a designer though.
The text was updated successfully, but these errors were encountered: