Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The main page is _just a little bit_ too tall, maybe? #237

Closed
torokati44 opened this issue Feb 16, 2024 · 4 comments
Closed

The main page is _just a little bit_ too tall, maybe? #237

torokati44 opened this issue Feb 16, 2024 · 4 comments

Comments

@torokati44
Copy link
Member

torokati44 commented Feb 16, 2024

This is highly subjective, but I think it would be nice if the main landing page would be entirely visible without scrolling on a 1080p display, in a maximized window, including any title/status/tool/task/panel bars, etc.

I think, for this, it would have to be just a little bit shorter, like ~900px tall, instead of the current ~960.
Tweaking some margins and paddings and spacings and sizes here and there should probably get us there easily.
I am not a designer though.

@danielhjacobs
Copy link
Collaborator

This is subjective, as you said. At work, my display is 1920x1200 and the Ruffle homepage is the perfect height for that size (see screenshot), but I acknowledge my monitor is larger than what most users have:
Screenshot from 2024-03-05 16-15-55
I'm also not a designer or I'd play around with this a bit.

@danielhjacobs
Copy link
Collaborator

170 extra, possibly unnecessary, pixels of margins.

@danielhjacobs
Copy link
Collaborator

danielhjacobs commented Nov 20, 2024

The page is also taller now that the links take up more lines.

Image

@danielhjacobs
Copy link
Collaborator

It's a bit hard to say how tall the content actually is now. On an OS without any relevant links. the only buttons shown are "Website Package" and "Other Downloads", taking up just one line on a wide screen. On most OS's and browsers, the links instead take up 2-3 lines on a wide screen (3 lines as in the screenshot above, and 2 lines on most Windows and Mac computers or on an unsupported browser on Linux).

We can edit any of these three files, but screen sizes and window borders also vary a lot.



.logo {
height: 220px;
width: 400px;
}

And tbh the biggest issue may be once we support i18n, the translations could end up making the page taller or shorter depending on the chosen language, and we can't monitor the size for every language.

@danielhjacobs danielhjacobs closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants