Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The menu has some strange empty space at the bottom on mobile #238

Closed
torokati44 opened this issue Feb 16, 2024 · 2 comments
Closed

The menu has some strange empty space at the bottom on mobile #238

torokati44 opened this issue Feb 16, 2024 · 2 comments

Comments

@torokati44
Copy link
Member

Here:

Screenshot_20240216-141307

I don't know why it's there, but doesn't seem necessary.
Not a big deal though!

danielhjacobs added a commit to danielhjacobs/ruffle-rs.github.io that referenced this issue Mar 5, 2024
danielhjacobs added a commit to danielhjacobs/ruffle-rs.github.io that referenced this issue Mar 5, 2024
@danielhjacobs
Copy link
Collaborator

danielhjacobs commented Mar 5, 2024

The default style for that content area in the mantine Drawer is

height: var(--drawer-height, calc(100% - var(--drawer-offset) * 2));

As defined in https://github.com/mantinedev/mantine/blob/43c91731d52c416be7486c310fae04546caa1f9f/packages/%40mantine/core/src/components/Drawer/Drawer.module.css#L17

The default --drawer-offset is 0rem, as defined in https://github.com/mantinedev/mantine/blob/7b1457f9eb084f0fb663c25793d08877cc957db0/packages/%40mantine/core/src/components/Drawer/Drawer.module.css#L8

The default --drawer-height is --drawer-size when position is not 'right' or 'left': https://github.com/mantinedev/mantine/blob/7b1457f9eb084f0fb663c25793d08877cc957db0/packages/%40mantine/core/src/components/Drawer/DrawerRoot.tsx#L104-L105

The default --drawer-size is --drawer-size-md according to https://github.com/mantinedev/mantine/blob/43c91731d52c416be7486c310fae04546caa1f9f/packages/%40mantine/core/src/components/Drawer/Drawer.module.css#L7

The default --drawer-size-md is rem(440px) according to https://github.com/mantinedev/mantine/blob/43c91731d52c416be7486c310fae04546caa1f9f/packages/%40mantine/core/src/components/Drawer/Drawer.module.css#L4

The rem is 16px, so that's 27.5rem. So that's the height of the mantine Drawer content area by default. I opened a PR to make its height auto instead.

@torokati44
Copy link
Member Author

Yay, thanks for the fix! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants