Skip to content

Conversation

@henriklundstrom
Copy link
Contributor

what

Use the conclusion of the check suite instead of the conclusion of the individual check run when determining if a pull request with a required workflow is mergeable when the gh-allow-mergeable-bypass-apply-flag is enabled.

  • Use check suite conclusion rather than check run conclusion to determine required workflow outcome

why

  • Resolves the issue Mergeability may be determined wrongfully on required workflows with multiple checks #5884
  • The conclusion of an individual check run is insufficient for determining the conclusion of a workflow as it may have multiple check runs, the outcomes of which may differ, meaning a successful check run does not necessarily entail a successful workflow. Use the conclusion of the check suite instead, which holds the combined conclusion of each associated check run.

tests

  • Adding a test case where a required workflow has multiple checks in the same suite but only the first is successful
    • This test fails with the implementation on main, but passes with the changes made by this PR
  • Making a release on this feature branch: https://github.com/nordnet/atlantis/releases/tag/v0.37.0-pre.mergeability-from-check-suite-20250929-001
    • See the associated Docker image: ghcr.io/nordnet/atlantis:v0.37.0-pre.mergeability-from-check-suite-20250929-001-alpine@sha256:d7153cc2916d9c9bc0c6743ad1732bdea8d7eca73a1cd944f9f959695397cde5

references

@github-actions github-actions bot added go Pull requests that update Go code provider/github labels Oct 13, 2025
@dosubot dosubot bot added the bug Something isn't working label Oct 13, 2025
@henriklundstrom henriklundstrom force-pushed the f/henriklundstrom/mergeability-from-check-suite branch from 7cce7d5 to 5107164 Compare October 13, 2025 12:25
Copy link
Contributor

@lukemassa lukemassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 13, 2025
Copy link

@nvanheuverzwijn nvanheuverzwijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went extensively through this part of the code (for another unrelated bug) and this PR looks good to me.

@henriklundstrom
Copy link
Contributor Author

Looks good to me!

@lukemassa is there anything more I should do in order to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code lgtm This PR has been approved by a maintainer provider/github

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants