Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kompilation cache in the intergration tests #2419

Closed
geo2a opened this issue May 9, 2024 · 0 comments · Fixed by #2430
Closed

Refactor kompilation cache in the intergration tests #2419

geo2a opened this issue May 9, 2024 · 0 comments · Fixed by #2430
Assignees

Comments

@geo2a
Copy link
Contributor

geo2a commented May 9, 2024

As a follow-up to #2417, @tothtamas28 suggest we should do the following:

As I see it, tests basically require an interface that takes a Target and returns a Path to the kompiled target (in the actual tests there might be another indirection from spec files to targets, but I'll not consider this for simplicity).

So you just have to ensure that Target -> Path is reproducible between runs, then accommodating both use cases (prekompiled vs on-the-fly) is straightforward.

If the Path does not exist, lock and kompile
Otherwise, return the Path.

For prekompiled mode, you pass in a non-empty directory as base. For on-the-file mode, you pass in an empty temporary directory.

cache, etc. can be dropped, the actual cache is the file system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants