Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Build script not running #51

Closed
AliSajid opened this issue Sep 11, 2022 · 3 comments
Closed

Pre-Build script not running #51

AliSajid opened this issue Sep 11, 2022 · 3 comments
Labels
bug Something isn't working needs-testing Needs further testing to narrow down problem

Comments

@AliSajid
Copy link

Hi,

Thank you for this action. It has been very helpful. However, I recently migrated to using semantic release to automatically creating my releases and have had the same trouble as #46 . I am using a work around for that that uses a pre-build script but that script doesn't appear to run.

The repo I'm running this on is AliSajid/iptmnet_client and the workflow is in .github/workflows/release.yaml. The pre-build script is in meta/pre-build.sh.

@Douile Douile added bug Something isn't working needs-testing Needs further testing to narrow down problem labels Oct 24, 2022
@larsnaesbye
Copy link

Yes, I have the same problem. I even added a echo line to scream out whether we hit the script, and it doesn't activate.

@larsnaesbye
Copy link

Ah. It needs to be quoted to run.

@AliSajid
Copy link
Author

Following @larsnaesbye , I quoted it and it works. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-testing Needs further testing to narrow down problem
Development

No branches or pull requests

3 participants