Skip to content

Commit 8ace2cd

Browse files
committed
chore: Apply review feedback
Signed-off-by: Brennan Kinney <[email protected]>
1 parent 34f3927 commit 8ace2cd

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

src/file/format/ini.rs

+13-13
Original file line numberDiff line numberDiff line change
@@ -22,26 +22,26 @@ fn from_ini(
2222
uri: Option<&String>,
2323
data: Ini,
2424
) -> Value {
25-
let mut map = Map::new();
25+
let mut map = Map::<String, Value>::new();
2626

2727
let mut sections: Map<Option<&str>, Table> = data.into_iter().map(|(section, props)| {(
2828
section,
29-
props.iter().map(|(k, v)| {(
30-
k.to_owned(),
31-
Value::new(uri, ValueKind::String(v.to_owned())),
32-
)}).collect()
29+
props.iter().map(|(k, v)| {
30+
let key = k.to_owned();
31+
let value = Value::new(uri, ValueKind::String(v.to_owned()));
32+
(key, value)
33+
}).collect()
3334
)}).collect();
3435

35-
// These (optional) properties should exist top-level alongside sections:
36-
if let Some(sectionless) = sections.remove(&None) {
37-
map.extend(sectionless);
38-
}
36+
// Hoist (optional) sectionless properties to the top-level, alongside sections:
37+
map.extend(sections.remove(&None).unwrap_or_default());
3938

4039
// Wrap each section Table into Value for merging into `map`:
41-
map.extend(sections.into_iter().map(|(k,v)| {(
42-
k.unwrap_or_default().to_owned(),
43-
Value::new(uri, ValueKind::Table(v)),
44-
)}));
40+
map.extend(sections.into_iter().map(|(k,v)| {
41+
let key = k.unwrap_or_default().to_owned();
42+
let value = Value::new(uri, ValueKind::Table(v));
43+
(key , value)
44+
}));
4545

4646
Value::new(uri, ValueKind::Table(map))
4747
}

0 commit comments

Comments
 (0)