Skip to content

Policy: Require MCP and relevant team nominations for adding (ecosystem, custom codegen backend) testing jobs that would block PR/Merge CI and require documenting failure protocol #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
jieyouxu opened this issue Mar 3, 2025 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Mar 3, 2025

Proposal

New policy: Require compiler MCP and a library team review for adding new ecosystem/integration test jobs/components to rust-lang/rust CI

The policy draft is at rust-lang/rust-forge#813. Please leave review feedback against that PR for the policy wording / details.

This policy is retroactive for existing ecosystem/integration test jobs/components

This requirement is intended to be retroactive. I will file MCPs for the existing ecosystem/integration test jobs/components (or at least partially; we will need to work with the ecosystem/integration test job/component maintainers to fill the details out). If they are accepted, then no actions need to be done. If there are outstanding blocking concerns, then we may modify or remove the existing ecosystem/integration test jobs/components if the concerns are substantial and cannot be resolved in a timely fashion (as a last resort).

Mentors or Reviewers

@davidtwco and @wesleywiser

This should also be discussed with T-{rustdoc,infra,bootstrap,libs} members.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

@jieyouxu jieyouxu added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Mar 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2025

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rfcbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rfcbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Mar 3, 2025
@jieyouxu jieyouxu changed the title Policy: Require MCP for adding (ecosystem) testing jobs that would block PR/Merge CI and require documenting failure protocol Policy: Require MCP for adding (ecosystem, custom codegen backend) testing jobs that would block PR/Merge CI and require documenting failure protocol Mar 3, 2025
@jieyouxu jieyouxu changed the title Policy: Require MCP for adding (ecosystem, custom codegen backend) testing jobs that would block PR/Merge CI and require documenting failure protocol Policy: Require MCP and relevant team nominations for adding (ecosystem, custom codegen backend) testing jobs that would block PR/Merge CI and require documenting failure protocol Mar 3, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 7, 2025
@davidtwco
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Mar 20, 2025
@apiraino
Copy link
Contributor

apiraino commented Apr 4, 2025

@rustbot label -final-comment-period +major-change-accepted

@apiraino apiraino closed this as completed Apr 4, 2025
@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Apr 4, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants