-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display doc comments for private types #911
Comments
Support for custom rustdoc arguments was merged a while ago, so we should be able to expose private types' documentation on docs.rs. |
Hi. I'm interested in implementing this. Can I be assigned. thanks |
Don't think we assign issues with this repo, you can just start working on it and submit a PR when you're ready :). Let us know if you have any questions :). |
cool. thanks |
Fixes rust-lang#911 - Adds a [package.metadata.docs.rs] to Cargo.toml - Sets the rustdoc-args key to [ "--no-defaults --passes collapse-docs --passes unindent-comments" ]
Hi I have created a PR: #1042 that implements the tasks in the description. |
Hmmmmmm, so I published cargo-registry 0.2.0, and it's up on docs.rs, but I don't see private things like the |
1047: Fix docs.rs metadata for docs of private types r=carols10cents Fixes: #911 Tested with [this crate](https://docs.rs/docsrs-test/0.0.4/docsrs_test/).
v0.2.1 works!!!!! https://docs.rs/cargo-registry/0.2.1/cargo_registry/krate/index.html shows private stuff!! Thank you @mattgathu and @onur!! |
crates.io is documented as its own crate as cargo_registry, and the S3 interaction as cargo_registry_s3. I found out about how to display private types' documentation via
cargo doc --no-defaults --passes collapse-docs --passes unindent-comments
, but I don't think docs.rs has an option to do this for us. Is there an option to specify this another way e.g. in theCargo.toml
? Otherwise we could host the documentation on a different site ala Serde.Tasks involved in completing this, added by @carols10cents:
[package.metadata.docs.rs]
toCargo.toml
as shown in this PR descriptionrustdoc-args
key to[ "--no-defaults --passes collapse-docs --passes unindent-comments" ]
The text was updated successfully, but these errors were encountered: