rustc-args removed from Metadata

Docs.rs is never running rustc on main crate and because of this reason,
cargo is ignoring rustdoc-args when rustc-args set. Users must define
rustdoc-args to manipulate rustc.

Author: onur

src/docbuilder/metadata.rs

@@ -14,13 +14,12 @@ use toml::Value;
 /// ```text
 /// [package]
 /// name = "test"
-/// 
+///
 /// [package.metadata.docs.rs]
 /// features = [ "feature1", "feature2" ]
 /// all-features = true
 /// no-default-features = true
 /// default-target = "x86_64-unknown-linux-gnu"
-/// rustc-args = [ "--example-rustc-arg" ]
 /// rustdoc-args = [ "--example-rustdoc-arg" ]
 /// dependencies = [ "example-system-dependency" ]
 /// ```
@@ -44,9 +43,6 @@ pub struct Metadata {
     /// is always built on this target. You can change default target by setting this.
     pub default_target: Option<String>,
 
-    /// List of command line arguments for `rustc`.
-    pub rustc_args: Option<Vec<String>>,
-
     /// List of command line arguments for `rustdoc`.
     pub rustdoc_args: Option<Vec<String>>,
 
@@ -85,7 +81,6 @@ impl Metadata {
             all_features: false,
             no_default_features: false,
             default_target: None,
-            rustc_args: None,
             rustdoc_args: None,
             dependencies: None,
         }
@@ -112,8 +107,6 @@ impl Metadata {
                         .and_then(|v| v.as_bool()).unwrap_or(metadata.all_features);
                     metadata.default_target = table.get("default-target")
                         .and_then(|v| v.as_str()).map(|v| v.to_owned());
-                    metadata.rustc_args = table.get("rustc-args").and_then(|f| f.as_array())
-                        .and_then(|f| f.iter().map(|v| v.as_str().map(|v| v.to_owned())).collect());
                     metadata.rustdoc_args = table.get("rustdoc-args").and_then(|f| f.as_array())
                         .and_then(|f| f.iter().map(|v| v.as_str().map(|v| v.to_owned())).collect());
                     metadata.dependencies = table.get("dependencies").and_then(|f| f.as_array())
@@ -154,7 +147,6 @@ mod test {
         assert!(metadata.all_features == true);
         assert!(metadata.no_default_features == true);
         assert!(metadata.default_target.is_some());
-        assert!(metadata.rustc_args.is_some());
         assert!(metadata.rustdoc_args.is_some());
 
         let features = metadata.features.unwrap();
@@ -164,10 +156,6 @@ mod test {
 
         assert_eq!(metadata.default_target.unwrap(), "x86_64-unknown-linux-gnu".to_owned());
 
-        let rustc_args = metadata.rustc_args.unwrap();
-        assert_eq!(rustc_args.len(), 1);
-        assert_eq!(rustc_args[0], "--example-rustc-arg".to_owned());
-
         let rustdoc_args = metadata.rustdoc_args.unwrap();
         assert_eq!(rustdoc_args.len(), 1);
         assert_eq!(rustdoc_args[0], "--example-rustdoc-arg".to_owned());

src/utils/build_doc.rs

@@ -63,9 +63,6 @@ pub fn build_doc(name: &str, vers: Option<&str>, target: Option<&str>) -> CargoR
                                         &[], false,
                                         &[], false,
                                         &[], false),
-        // FIXME: cargo is ignoring target_rustdoc_args if rustc_args set.
-        //        I believe this is expected behavior when building docs but I am not sure.
-        //        This needs to be investigated.
         target_rustc_args: None,
         target_rustdoc_args: metadata.rustdoc_args.as_ref().map(Vec::as_slice),
     };