don't clone in get_rustdoc

syphar · GuillaumeGomez · commit 13d4ccea78ce · 2025-01-12T21:47:47.000+01:00
diff --git a/src/db/add_package.rs b/src/db/add_package.rs
@@ -447,7 +447,7 @@ fn get_readme(pkg: &MetadataPackage, source_dir: &Path) -> Result<Option<String>
 }
 
 fn get_rustdoc(pkg: &MetadataPackage, source_dir: &Path) -> Result<Option<String>> {
-    if let Some(src_path) = &pkg.targets.first().and_then(|t| t.src_path.clone()) {
+    if let Some(src_path) = &pkg.targets.first().and_then(|t| t.src_path.as_ref()) {
         let src_path = Path::new(src_path);
         if src_path.is_absolute() {
             read_rust_doc(src_path)

Original file line number	Diff line number	Diff line change
`@@ -447,7 +447,7 @@ fn get_readme(pkg: &MetadataPackage, source_dir: &Path) -> Result<Option<String>`
`447`	`447`	`}`
`448`	`448`
`449`	`449`	`fn get_rustdoc(pkg: &MetadataPackage, source_dir: &Path) -> Result<Option<String>> {`
`450`		`- if let Some(src_path) = &pkg.targets.first().and_then(\|t\| t.src_path.clone()) {`
	`450`	`+ if let Some(src_path) = &pkg.targets.first().and_then(\|t\| t.src_path.as_ref()) {`
`451`	`451`	`let src_path = Path::new(src_path);`
`452`	`452`	`if src_path.is_absolute() {`
`453`	`453`	`read_rust_doc(src_path)`