simplify clippy ci

Author: nyurik

.github/workflows/ci.yaml

@@ -29,6 +29,18 @@ jobs:
       - name: Check style
         run: ./ci/style.sh
 
+  clippy:
+    name: Clippy check
+    runs-on: ubuntu-24.04
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v4
+      - uses: Swatinem/rust-cache@v2
+      # Here we use the latest stable Rust toolchain already installed by GitHub
+      # Ideally we should run it for every target, but we cannot rely on unstable toolchains
+      # due to Clippy not being consistent between them.
+      - run: cargo clippy --workspace --exclude libc-test --exclude ctest-test --all-targets -- -D warnings
+
   # This runs `cargo build --target ...` for all T1 and T2 targets`
   verify_build:
     name: Verify build

ci/style.sh

@@ -4,9 +4,6 @@ set -eux
 
 [ -n "${CI:-}" ] && check="--check"
 
-# TODO: for some reason using `--workspace` validates a lot of generated code in ./target/** dir
-cargo clippy -p [email protected] -p ctest --all-targets -- -D warnings
-
 cargo test --manifest-path libc-test/Cargo.toml --test style -- --nocapture
 
 command -v rustfmt

ci/verify-build.sh

@@ -44,13 +44,9 @@ test_target() {
     # The basic command that is run each time
     cmd="cargo +$rust build --target $target"
 
-    # The basic clippy command
-    clippy_cmd="cargo +$rust clippy --all-targets --target $target"
-
     if [ "${no_dist}" != "0" ]; then
         # If we can't download a `core`, we need to build it
         cmd="$cmd -Zbuild-std=core,alloc"
-        clippy_cmd="$clippy_cmd -Zbuild-std=core,alloc"
 
         # FIXME: With `build-std` feature, `compiler_builtins` emits a lof of lint warnings.
         RUSTFLAGS="${RUSTFLAGS:-} -Aimproper_ctypes_definitions"
@@ -71,9 +67,6 @@ test_target() {
         done
     fi
 
-    # Run cargo clippy first
-    $clippy_cmd
-
     # Test with expected combinations of features
     $cmd
     $cmd --features extra_traits