Skip to content

Commit 8e728d7

Browse files
lvllvltgross35
authored andcommitted
chore: add labels for FIXMEs in repo
(backport <#4237>) (cherry picked from commit 6c6674e)
1 parent 7f86bf8 commit 8e728d7

File tree

4 files changed

+41
-41
lines changed

4 files changed

+41
-41
lines changed

libc-test/build.rs

+19-19
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ fn test_apple(target: &str) {
268268
"os/clock.h",
269269
"os/lock.h",
270270
"os/signpost.h",
271-
// FIXME: Requires the macOS 14.4 SDK.
271+
// FIXME(macos): Requires the macOS 14.4 SDK.
272272
//"os/os_sync_wait_on_address.h",
273273
"poll.h",
274274
"pthread.h",
@@ -338,15 +338,15 @@ fn test_apple(target: &str) {
338338
return true;
339339
}
340340
match ty {
341-
// FIXME: actually a union
341+
// FIXME(union): actually a union
342342
"sigval" => true,
343343

344-
// FIXME: The size is changed in recent macOSes.
344+
// FIXME(macos): The size is changed in recent macOSes.
345345
"malloc_zone_t" => true,
346346
// it is a moving target, changing through versions
347347
// also contains bitfields members
348348
"tcp_connection_info" => true,
349-
// FIXME: The size is changed in recent macOSes.
349+
// FIXME(macos): The size is changed in recent macOSes.
350350
"malloc_introspection_t" => true,
351351

352352
_ => false,
@@ -358,10 +358,10 @@ fn test_apple(target: &str) {
358358
return true;
359359
}
360360
match ty {
361-
// FIXME: Requires the macOS 14.4 SDK.
361+
// FIXME(macos): Requires the macOS 14.4 SDK.
362362
"os_sync_wake_by_address_flags_t" | "os_sync_wait_on_address_flags_t" => true,
363363

364-
// FIXME: "'__uint128' undeclared" in C
364+
// FIXME(macos): "'__uint128' undeclared" in C
365365
"__uint128" => true,
366366

367367
_ => false,
@@ -377,13 +377,13 @@ fn test_apple(target: &str) {
377377
// These OSX constants are removed in Sierra.
378378
// https://developer.apple.com/library/content/releasenotes/General/APIDiffsMacOS10_12/Swift/Darwin.html
379379
"KERN_KDENABLE_BG_TRACE" | "KERN_KDDISABLE_BG_TRACE" => true,
380-
// FIXME: the value has been changed since Catalina (0xffff0000 -> 0x3fff0000).
380+
// FIXME(macos): the value has been changed since Catalina (0xffff0000 -> 0x3fff0000).
381381
"SF_SETTABLE" => true,
382382

383-
// FIXME: XCode 13.1 doesn't have it.
383+
// FIXME(macos): XCode 13.1 doesn't have it.
384384
"TIOCREMOTE" => true,
385385

386-
// FIXME: Requires the macOS 14.4 SDK.
386+
// FIXME(macos): Requires the macOS 14.4 SDK.
387387
"OS_SYNC_WAKE_BY_ADDRESS_NONE"
388388
| "OS_SYNC_WAKE_BY_ADDRESS_SHARED"
389389
| "OS_SYNC_WAIT_ON_ADDRESS_NONE"
@@ -402,19 +402,19 @@ fn test_apple(target: &str) {
402402
// close calls the close_nocancel system call
403403
"close" => true,
404404

405-
// FIXME: std removed libresolv support: https://github.com/rust-lang/rust/pull/102766
405+
// FIXME(1.0): std removed libresolv support: https://github.com/rust-lang/rust/pull/102766
406406
"res_init" => true,
407407

408-
// FIXME: remove once the target in CI is updated
408+
// FIXME(macos): remove once the target in CI is updated
409409
"pthread_jit_write_freeze_callbacks_np" => true,
410410

411-
// FIXME: ABI has been changed on recent macOSes.
411+
// FIXME(macos): ABI has been changed on recent macOSes.
412412
"os_unfair_lock_assert_owner" | "os_unfair_lock_assert_not_owner" => true,
413413

414-
// FIXME: Once the SDK get updated to Ventura's level
414+
// FIXME(macos): Once the SDK get updated to Ventura's level
415415
"freadlink" | "mknodat" | "mkfifoat" => true,
416416

417-
// FIXME: Requires the macOS 14.4 SDK.
417+
// FIXME(macos): Requires the macOS 14.4 SDK.
418418
"os_sync_wake_by_address_any"
419419
| "os_sync_wake_by_address_all"
420420
| "os_sync_wake_by_address_flags_t"
@@ -429,7 +429,7 @@ fn test_apple(target: &str) {
429429

430430
cfg.skip_field(move |struct_, field| {
431431
match (struct_, field) {
432-
// FIXME: the array size has been changed since macOS 10.15 ([8] -> [7]).
432+
// FIXME(macos): the array size has been changed since macOS 10.15 ([8] -> [7]).
433433
("statfs", "f_reserved") => true,
434434
("__darwin_arm_neon_state64", "__v") => true,
435435
// MAXPATHLEN is too big for auto-derive traits on arrays.
@@ -447,7 +447,7 @@ fn test_apple(target: &str) {
447447

448448
cfg.skip_field_type(move |struct_, field| {
449449
match (struct_, field) {
450-
// FIXME: actually a union
450+
// FIXME(union): actually a union
451451
("sigevent", "sigev_value") => true,
452452
_ => false,
453453
}
@@ -481,7 +481,7 @@ fn test_apple(target: &str) {
481481
s if s.ends_with("_nsec") && struct_.starts_with("stat") => {
482482
s.replace("e_nsec", "espec.tv_nsec")
483483
}
484-
// FIXME: sigaction actually contains a union with two variants:
484+
// FIXME(macos): sigaction actually contains a union with two variants:
485485
// a sa_sigaction with type: (*)(int, struct __siginfo *, void *)
486486
// a sa_handler with type sig_t
487487
"sa_sigaction" if struct_ == "sigaction" => "sa_handler".to_string(),
@@ -490,7 +490,7 @@ fn test_apple(target: &str) {
490490
});
491491

492492
cfg.skip_roundtrip(move |s| match s {
493-
// FIXME: this type has the wrong ABI
493+
// FIXME(macos): this type has the wrong ABI
494494
"max_align_t" if i686 => true,
495495
// Can't return an array from a C function.
496496
"uuid_t" | "vol_capabilities_set_t" => true,
@@ -597,7 +597,7 @@ fn test_openbsd(target: &str) {
597597
return true;
598598
}
599599
match ty {
600-
// FIXME: actually a union
600+
// FIXME(union): actually a union
601601
"sigval" => true,
602602

603603
_ => false,

src/fuchsia/mod.rs

+18-18
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ pub type rlim_t = c_ulonglong;
9191
pub type c_long = i64;
9292
pub type c_ulong = u64;
9393

94-
// FIXME: why are these uninhabited types? that seems... wrong?
94+
// FIXME(fuchsia): why are these uninhabited types? that seems... wrong?
9595
// Presumably these should be `()` or an `extern type` (when that stabilizes).
9696
#[cfg_attr(feature = "extra_traits", derive(Debug))]
9797
pub enum timezone {}
@@ -111,7 +111,7 @@ impl Clone for DIR {
111111
}
112112

113113
#[cfg_attr(feature = "extra_traits", derive(Debug))]
114-
pub enum fpos64_t {} // FIXME: fill this out with a struct
114+
pub enum fpos64_t {} // FIXME(fuchsia): fill this out with a struct
115115
impl Copy for fpos64_t {}
116116
impl Clone for fpos64_t {
117117
fn clone(&self) -> fpos64_t {
@@ -144,7 +144,7 @@ s! {
144144
pub tv_nsec: c_long,
145145
}
146146

147-
// FIXME: the rlimit and rusage related functions and types don't exist
147+
// FIXME(fuchsia): the rlimit and rusage related functions and types don't exist
148148
// within zircon. Are there reasons for keeping them around?
149149
pub struct rlimit {
150150
pub rlim_cur: rlim_t,
@@ -478,7 +478,7 @@ s! {
478478
pub ifa_flags: c_uint,
479479
pub ifa_addr: *mut crate::sockaddr,
480480
pub ifa_netmask: *mut crate::sockaddr,
481-
pub ifa_ifu: *mut crate::sockaddr, // FIXME This should be a union
481+
pub ifa_ifu: *mut crate::sockaddr, // FIXME(union) This should be a union
482482
pub ifa_data: *mut c_void,
483483
}
484484

@@ -1097,7 +1097,7 @@ cfg_if! {
10971097
.field("totalhigh", &self.totalhigh)
10981098
.field("freehigh", &self.freehigh)
10991099
.field("mem_unit", &self.mem_unit)
1100-
// FIXME: .field("__reserved", &self.__reserved)
1100+
// FIXME(debug): .field("__reserved", &self.__reserved)
11011101
.finish()
11021102
}
11031103
}
@@ -1135,7 +1135,7 @@ cfg_if! {
11351135
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
11361136
f.debug_struct("sockaddr_un")
11371137
.field("sun_family", &self.sun_family)
1138-
// FIXME: .field("sun_path", &self.sun_path)
1138+
// FIXME(debug): .field("sun_path", &self.sun_path)
11391139
.finish()
11401140
}
11411141
}
@@ -1163,7 +1163,7 @@ cfg_if! {
11631163
f.debug_struct("sockaddr_storage")
11641164
.field("ss_family", &self.ss_family)
11651165
.field("__ss_align", &self.__ss_align)
1166-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
1166+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
11671167
.finish()
11681168
}
11691169
}
@@ -1207,11 +1207,11 @@ cfg_if! {
12071207
impl fmt::Debug for utsname {
12081208
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
12091209
f.debug_struct("utsname")
1210-
// FIXME: .field("sysname", &self.sysname)
1211-
// FIXME: .field("nodename", &self.nodename)
1212-
// FIXME: .field("release", &self.release)
1213-
// FIXME: .field("version", &self.version)
1214-
// FIXME: .field("machine", &self.machine)
1210+
// FIXME(debug): .field("sysname", &self.sysname)
1211+
// FIXME(debug): .field("nodename", &self.nodename)
1212+
// FIXME(debug): .field("release", &self.release)
1213+
// FIXME(debug): .field("version", &self.version)
1214+
// FIXME(debug): .field("machine", &self.machine)
12151215
.finish()
12161216
}
12171217
}
@@ -1246,7 +1246,7 @@ cfg_if! {
12461246
.field("d_off", &self.d_off)
12471247
.field("d_reclen", &self.d_reclen)
12481248
.field("d_type", &self.d_type)
1249-
// FIXME: .field("d_name", &self.d_name)
1249+
// FIXME(debug): .field("d_name", &self.d_name)
12501250
.finish()
12511251
}
12521252
}
@@ -1281,7 +1281,7 @@ cfg_if! {
12811281
.field("d_off", &self.d_off)
12821282
.field("d_reclen", &self.d_reclen)
12831283
.field("d_type", &self.d_type)
1284-
// FIXME: .field("d_name", &self.d_name)
1284+
// FIXME(debug): .field("d_name", &self.d_name)
12851285
.finish()
12861286
}
12871287
}
@@ -1390,7 +1390,7 @@ cfg_if! {
13901390
impl fmt::Debug for pthread_cond_t {
13911391
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
13921392
f.debug_struct("pthread_cond_t")
1393-
// FIXME: .field("size", &self.size)
1393+
// FIXME(debug): .field("size", &self.size)
13941394
.finish()
13951395
}
13961396
}
@@ -1409,7 +1409,7 @@ cfg_if! {
14091409
impl fmt::Debug for pthread_mutex_t {
14101410
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
14111411
f.debug_struct("pthread_mutex_t")
1412-
// FIXME: .field("size", &self.size)
1412+
// FIXME(debug): .field("size", &self.size)
14131413
.finish()
14141414
}
14151415
}
@@ -1428,7 +1428,7 @@ cfg_if! {
14281428
impl fmt::Debug for pthread_rwlock_t {
14291429
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
14301430
f.debug_struct("pthread_rwlock_t")
1431-
// FIXME: .field("size", &self.size)
1431+
// FIXME(debug): .field("size", &self.size)
14321432
.finish()
14331433
}
14341434
}
@@ -3562,7 +3562,7 @@ impl Clone for FILE {
35623562
}
35633563
}
35643564
#[cfg_attr(feature = "extra_traits", derive(Debug))]
3565-
pub enum fpos_t {} // FIXME: fill this out with a struct
3565+
pub enum fpos_t {} // FIXME(fuchsia): fill this out with a struct
35663566
impl Copy for fpos_t {}
35673567
impl Clone for fpos_t {
35683568
fn clone(&self) -> fpos_t {

src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
redundant_semicolons,
1313
unused_macros,
1414
unused_macro_rules,
15-
// FIXME: temporarily allow dead_code to fix CI:
15+
// FIXME(1.0): temporarily allow dead_code to fix CI:
1616
// - https://github.com/rust-lang/libc/issues/3740
1717
// - https://github.com/rust-lang/rust/pull/126456
1818
dead_code,

src/vxworks/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ pub const EAI_SERVICE: c_int = 9;
562562
pub const EAI_SOCKTYPE: c_int = 10;
563563
pub const EAI_SYSTEM: c_int = 11;
564564

565-
// FIXME: This is not defined in vxWorks, but we have to define it here
565+
// FIXME(vxworks): This is not defined in vxWorks, but we have to define it here
566566
// to make the building pass for getrandom and std
567567
pub const RTLD_DEFAULT: *mut c_void = 0i64 as *mut c_void;
568568

@@ -725,7 +725,7 @@ pub const S_taskLib_TASK_HOOK_TABLE_FULL: c_int = taskErrorBase + 0x0066;
725725
pub const S_taskLib_TASK_HOOK_NOT_FOUND: c_int = taskErrorBase + 0x0067;
726726
pub const S_taskLib_ILLEGAL_PRIORITY: c_int = taskErrorBase + 0x0068;
727727

728-
// FIXME: could also be useful for TASK_DESC type
728+
// FIXME(vxworks): could also be useful for TASK_DESC type
729729
pub const VX_TASK_NAME_LENGTH: c_int = 31;
730730

731731
// semLibCommon.h
@@ -1066,7 +1066,7 @@ impl Clone for FILE {
10661066
}
10671067
}
10681068
#[cfg_attr(feature = "extra_traits", derive(Debug))]
1069-
pub enum fpos_t {} // FIXME: fill this out with a struct
1069+
pub enum fpos_t {} // FIXME(vxworks): fill this out with a struct
10701070
impl Copy for fpos_t {}
10711071
impl Clone for fpos_t {
10721072
fn clone(&self) -> fpos_t {

0 commit comments

Comments
 (0)