Skip to content

Commit 6b1e7f6

Browse files
Merge pull request #371 from rust-lang/lane_to_element
Rename "lane" to "element"
2 parents f510c6b + 4cc260e commit 6b1e7f6

23 files changed

+486
-491
lines changed

crates/core_simd/examples/matrix_inversion.rs

+19-19
Original file line numberDiff line numberDiff line change
@@ -179,58 +179,58 @@ pub fn simd_inv4x4(m: Matrix4x4) -> Option<Matrix4x4> {
179179
let row2 = simd_swizzle!(tmp, row3, SHUFFLE02);
180180
let row3 = simd_swizzle!(row3, tmp, SHUFFLE13);
181181

182-
let tmp = (row2 * row3).reverse().rotate_lanes_right::<2>();
182+
let tmp = (row2 * row3).reverse().rotate_elements_right::<2>();
183183
let minor0 = row1 * tmp;
184184
let minor1 = row0 * tmp;
185-
let tmp = tmp.rotate_lanes_right::<2>();
185+
let tmp = tmp.rotate_elements_right::<2>();
186186
let minor0 = (row1 * tmp) - minor0;
187187
let minor1 = (row0 * tmp) - minor1;
188-
let minor1 = minor1.rotate_lanes_right::<2>();
188+
let minor1 = minor1.rotate_elements_right::<2>();
189189

190-
let tmp = (row1 * row2).reverse().rotate_lanes_right::<2>();
190+
let tmp = (row1 * row2).reverse().rotate_elements_right::<2>();
191191
let minor0 = (row3 * tmp) + minor0;
192192
let minor3 = row0 * tmp;
193-
let tmp = tmp.rotate_lanes_right::<2>();
193+
let tmp = tmp.rotate_elements_right::<2>();
194194

195195
let minor0 = minor0 - row3 * tmp;
196196
let minor3 = row0 * tmp - minor3;
197-
let minor3 = minor3.rotate_lanes_right::<2>();
197+
let minor3 = minor3.rotate_elements_right::<2>();
198198

199-
let tmp = (row3 * row1.rotate_lanes_right::<2>())
199+
let tmp = (row3 * row1.rotate_elements_right::<2>())
200200
.reverse()
201-
.rotate_lanes_right::<2>();
202-
let row2 = row2.rotate_lanes_right::<2>();
201+
.rotate_elements_right::<2>();
202+
let row2 = row2.rotate_elements_right::<2>();
203203
let minor0 = row2 * tmp + minor0;
204204
let minor2 = row0 * tmp;
205-
let tmp = tmp.rotate_lanes_right::<2>();
205+
let tmp = tmp.rotate_elements_right::<2>();
206206
let minor0 = minor0 - row2 * tmp;
207207
let minor2 = row0 * tmp - minor2;
208-
let minor2 = minor2.rotate_lanes_right::<2>();
208+
let minor2 = minor2.rotate_elements_right::<2>();
209209

210-
let tmp = (row0 * row1).reverse().rotate_lanes_right::<2>();
210+
let tmp = (row0 * row1).reverse().rotate_elements_right::<2>();
211211
let minor2 = minor2 + row3 * tmp;
212212
let minor3 = row2 * tmp - minor3;
213-
let tmp = tmp.rotate_lanes_right::<2>();
213+
let tmp = tmp.rotate_elements_right::<2>();
214214
let minor2 = row3 * tmp - minor2;
215215
let minor3 = minor3 - row2 * tmp;
216216

217-
let tmp = (row0 * row3).reverse().rotate_lanes_right::<2>();
217+
let tmp = (row0 * row3).reverse().rotate_elements_right::<2>();
218218
let minor1 = minor1 - row2 * tmp;
219219
let minor2 = row1 * tmp + minor2;
220-
let tmp = tmp.rotate_lanes_right::<2>();
220+
let tmp = tmp.rotate_elements_right::<2>();
221221
let minor1 = row2 * tmp + minor1;
222222
let minor2 = minor2 - row1 * tmp;
223223

224-
let tmp = (row0 * row2).reverse().rotate_lanes_right::<2>();
224+
let tmp = (row0 * row2).reverse().rotate_elements_right::<2>();
225225
let minor1 = row3 * tmp + minor1;
226226
let minor3 = minor3 - row1 * tmp;
227-
let tmp = tmp.rotate_lanes_right::<2>();
227+
let tmp = tmp.rotate_elements_right::<2>();
228228
let minor1 = minor1 - row3 * tmp;
229229
let minor3 = row1 * tmp + minor3;
230230

231231
let det = row0 * minor0;
232-
let det = det.rotate_lanes_right::<2>() + det;
233-
let det = det.reverse().rotate_lanes_right::<2>() + det;
232+
let det = det.rotate_elements_right::<2>() + det;
233+
let det = det.reverse().rotate_elements_right::<2>() + det;
234234

235235
if det.reduce_sum() == 0. {
236236
return None;

crates/core_simd/src/fmt.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
use crate::simd::{LaneCount, Simd, SimdElement, SupportedLaneCount};
22
use core::fmt;
33

4-
impl<T, const LANES: usize> fmt::Debug for Simd<T, LANES>
4+
impl<T, const N: usize> fmt::Debug for Simd<T, N>
55
where
6-
LaneCount<LANES>: SupportedLaneCount,
6+
LaneCount<N>: SupportedLaneCount,
77
T: SimdElement + fmt::Debug,
88
{
99
/// A `Simd<T, N>` has a debug format like the one for `[T]`:

crates/core_simd/src/iter.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -6,39 +6,39 @@ use core::{
66

77
macro_rules! impl_traits {
88
{ $type:ty } => {
9-
impl<const LANES: usize> Sum<Self> for Simd<$type, LANES>
9+
impl<const N: usize> Sum<Self> for Simd<$type, N>
1010
where
11-
LaneCount<LANES>: SupportedLaneCount,
11+
LaneCount<N>: SupportedLaneCount,
1212
{
1313
#[inline]
1414
fn sum<I: Iterator<Item = Self>>(iter: I) -> Self {
1515
iter.fold(Simd::splat(0 as $type), Add::add)
1616
}
1717
}
1818

19-
impl<const LANES: usize> Product<Self> for Simd<$type, LANES>
19+
impl<const N: usize> Product<Self> for Simd<$type, N>
2020
where
21-
LaneCount<LANES>: SupportedLaneCount,
21+
LaneCount<N>: SupportedLaneCount,
2222
{
2323
#[inline]
2424
fn product<I: Iterator<Item = Self>>(iter: I) -> Self {
2525
iter.fold(Simd::splat(1 as $type), Mul::mul)
2626
}
2727
}
2828

29-
impl<'a, const LANES: usize> Sum<&'a Self> for Simd<$type, LANES>
29+
impl<'a, const N: usize> Sum<&'a Self> for Simd<$type, N>
3030
where
31-
LaneCount<LANES>: SupportedLaneCount,
31+
LaneCount<N>: SupportedLaneCount,
3232
{
3333
#[inline]
3434
fn sum<I: Iterator<Item = &'a Self>>(iter: I) -> Self {
3535
iter.fold(Simd::splat(0 as $type), Add::add)
3636
}
3737
}
3838

39-
impl<'a, const LANES: usize> Product<&'a Self> for Simd<$type, LANES>
39+
impl<'a, const N: usize> Product<&'a Self> for Simd<$type, N>
4040
where
41-
LaneCount<LANES>: SupportedLaneCount,
41+
LaneCount<N>: SupportedLaneCount,
4242
{
4343
#[inline]
4444
fn product<I: Iterator<Item = &'a Self>>(iter: I) -> Self {

crates/core_simd/src/lane_count.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ mod sealed {
44
use sealed::Sealed;
55

66
/// Specifies the number of lanes in a SIMD vector as a type.
7-
pub struct LaneCount<const LANES: usize>;
7+
pub struct LaneCount<const N: usize>;
88

9-
impl<const LANES: usize> LaneCount<LANES> {
9+
impl<const N: usize> LaneCount<N> {
1010
/// The number of bytes in a bitmask with this many lanes.
11-
pub const BITMASK_LEN: usize = (LANES + 7) / 8;
11+
pub const BITMASK_LEN: usize = (N + 7) / 8;
1212
}
1313

1414
/// Statically guarantees that a lane count is marked as supported.
@@ -21,7 +21,7 @@ pub trait SupportedLaneCount: Sealed {
2121
type BitMask: Copy + Default + AsRef<[u8]> + AsMut<[u8]>;
2222
}
2323

24-
impl<const LANES: usize> Sealed for LaneCount<LANES> {}
24+
impl<const N: usize> Sealed for LaneCount<N> {}
2525

2626
macro_rules! supported_lane_count {
2727
($($lanes:literal),+) => {

0 commit comments

Comments
 (0)