fix: mutex_atomic wrongly unmangled macros

Author: profetia

clippy_lints/src/mutex_atomic.rs

@@ -143,7 +143,7 @@ fn check_expr<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'tcx>, ty_ascription: &T
                 && new.ident.name == sym::new
             {
                 let mut applicability = Applicability::MaybeIncorrect;
-                let arg = Sugg::hir_with_applicability(cx, arg, "_", &mut applicability);
+                let arg = Sugg::hir_with_context(cx, arg, expr.span.ctxt(), "_", &mut applicability);
                 let mut suggs = vec![(expr.span, format!("std::sync::atomic::{atomic_name}::new({arg})"))];
                 match ty_ascription {
                     TypeAscriptionKind::Required(ty_ascription) => {

tests/ui/mutex_atomic.fixed

@@ -65,3 +65,15 @@ fn issue13378() {
     let (funky_mtx) = std::sync::atomic::AtomicU64::new(0);
     //~^ mutex_integer
 }
+
+fn wrongly_unmangled_macros() {
+    macro_rules! test_expr {
+        ($val:expr) => {
+            ($val > 0 && true)
+        };
+    }
+
+    let _ = std::sync::atomic::AtomicBool::new(test_expr!(1));
+    //~^ mutex_atomic
+    // The suggestion should preserve the macro call: `AtomicBool::new(test_expr!(true))`
+}

tests/ui/mutex_atomic.rs

@@ -65,3 +65,15 @@ fn issue13378() {
     let (funky_mtx): Mutex<u64> = Mutex::new(0);
     //~^ mutex_integer
 }
+
+fn wrongly_unmangled_macros() {
+    macro_rules! test_expr {
+        ($val:expr) => {
+            ($val > 0 && true)
+        };
+    }
+
+    let _ = Mutex::new(test_expr!(1));
+    //~^ mutex_atomic
+    // The suggestion should preserve the macro call: `AtomicBool::new(test_expr!(true))`
+}

tests/ui/mutex_atomic.stderr

@@ -130,5 +130,13 @@ LL -     let (funky_mtx): Mutex<u64> = Mutex::new(0);
 LL +     let (funky_mtx) = std::sync::atomic::AtomicU64::new(0);
    |
 
-error: aborting due to 14 previous errors
+error: using a `Mutex` where an atomic would do
+  --> tests/ui/mutex_atomic.rs:76:13
+   |
+LL |     let _ = Mutex::new(test_expr!(1));
+   |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::sync::atomic::AtomicBool::new(test_expr!(1))`
+   |
+   = help: if you just want the locking behavior and not the internal type, consider using `Mutex<()>`
+
+error: aborting due to 15 previous errors